NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit51970fa

committed

Fix initialization of fake LSN for unlogged relations

9155580 has changed the value of the first fake LSN for unloggedrelations from 1 to FirstNormalUnloggedLSN (aka 1000), GiST requiring anon-zero LSN on some pages to allow an interlocking logic to work, butits value was still initialized to 1 at the beginning of recovery orafter running pg_resetwal. This fixes the initialization for both codepaths.Author: Takayuki TsunakawaReviewed-by: Dilip Kumar, Kyotaro Horiguchi, Michael PaquierDiscussion:https://postgr.es/m/OSBPR01MB2503CE851940C17DE44AE3D9FE6F0@OSBPR01MB2503.jpnprd01.prod.outlook.comBackpatch-through: 12

1 parentb804521 commit51970faCopy full SHA for 51970fa

File tree

2 files changed

-2

lines changed

src
- backend/access/transam
  - xlog.c
- bin/pg_resetwal
  - pg_resetwal.c

2 files changed

-2

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6687,7 +6687,7 @@ StartupXLOG(void)`
`6687`	`6687`	`if (ControlFile->state==DB_SHUTDOWNED)`
`6688`	`6688`	`XLogCtl->unloggedLSN=ControlFile->unloggedLSN;`
`6689`	`6689`	`else`
`6690`		`-XLogCtl->unloggedLSN=1;`
	`6690`	`+XLogCtl->unloggedLSN=FirstNormalUnloggedLSN;`
`6691`	`6691`
`6692`	`6692`	`/*`
`6693`	`6693`	`* We must replay WAL entries using the same TimeLineID they were created`

`‎src/bin/pg_resetwal/pg_resetwal.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -699,7 +699,7 @@ GuessControlValues(void)`
`699`	`699`	`ControlFile.state=DB_SHUTDOWNED;`
`700`	`700`	`ControlFile.time= (pg_time_t)time(NULL);`
`701`	`701`	`ControlFile.checkPoint=ControlFile.checkPointCopy.redo;`
`702`		`-ControlFile.unloggedLSN=1;`
	`702`	`+ControlFile.unloggedLSN=FirstNormalUnloggedLSN;`
`703`	`703`
`704`	`704`	`/* minRecoveryPoint, backupStartPoint and backupEndPoint can be left zero */`
`705`	`705`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit51970fa

File tree

2 files changed

2 files changed

`‎src/backend/access/transam/xlog.c`

`‎src/bin/pg_resetwal/pg_resetwal.c`

0 commit comments