NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit51891d5

committed

pg_basebackup: Cleaner handling when compression is multiply specified.

Tushar Ahuja discovered that if you use both --compress and --gzip,or --compress multiple times, the last instance of one of theseoptions doesn't in all cases overwrite the compression level set byan earlier option. That's not a serious bug, but it also has nothingto recommend it. Repair.Discussion:http://postgr.es/m/CA+TgmoZfP=rsZB_9vDGfhuNgSu_M_09UWu8SjvsP65y_1pQFCg@mail.gmail.com

1 parentda505ea commit51891d5Copy full SHA for 51891d5

File tree

1 file changed

-0

lines changed

src/bin/pg_basebackup
- pg_basebackup.c

1 file changed

-0

lines changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -966,6 +966,12 @@ parse_compress_options(char src, WalCompressionMethod methodres,`
`966`	`966`	`intfirstlen;`
`967`	`967`	`char*firstpart;`
`968`	`968`
	`969`	`+/*`
	`970`	`+ * clear 'levelres' so that if there are multiple compression options,`
	`971`	`+ * the last one fully overrides the earlier ones`
	`972`	`+ */`
	`973`	`+*levelres=0;`
	`974`	`+`
`969`	`975`	`/* check if the option is split in two */`
`970`	`976`	`sep=strchr(src,':');`
`971`	`977`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit51891d5

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

0 commit comments