NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5184f11

committed

Fix bad formula in previous commit.

Commitd5406de used a slightlynovel, and wrong, approach to compute the length of the lasttoast chunk. It worked fine unless the last chunk happened tohave the largest possible size.

1 parentd5406de commit5184f11Copy full SHA for 5184f11

File tree

1 file changed

-2

lines changed

src/backend/access/common
- detoast.c

1 file changed

-2

lines changed

`‎src/backend/access/common/detoast.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ toast_fetch_datum(struct varlena *attr)`
`443`	`443`	`toast_pointer.va_valueid,`
`444`	`444`	`RelationGetRelationName(toastrel))));`
`445`	`445`	`expected_size=curchunk<totalchunks-1 ?TOAST_MAX_CHUNK_SIZE`
`446`		`-:attrsize%TOAST_MAX_CHUNK_SIZE;`
	`446`	`+:attrsize- ((totalchunks-1)*TOAST_MAX_CHUNK_SIZE);`
`447`	`447`	`if (chunksize!=expected_size)`
`448`	`448`	`ereport(ERROR,`
`449`	`449`	`(errcode(ERRCODE_DATA_CORRUPTED),`
`@@ -676,7 +676,7 @@ toast_fetch_datum_slice(struct varlena *attr, int32 sliceoffset,`
`676`	`676`	`toast_pointer.va_valueid,`
`677`	`677`	`RelationGetRelationName(toastrel))));`
`678`	`678`	`expected_size=curchunk<totalchunks-1 ?TOAST_MAX_CHUNK_SIZE`
`679`		`-:attrsize%TOAST_MAX_CHUNK_SIZE;`
	`679`	`+:attrsize- ((totalchunks-1)*TOAST_MAX_CHUNK_SIZE);`
`680`	`680`	`if (chunksize!=expected_size)`
`681`	`681`	`ereport(ERROR,`
`682`	`682`	`(errcode(ERRCODE_DATA_CORRUPTED),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5184f11

File tree

1 file changed

1 file changed

`‎src/backend/access/common/detoast.c‎`

0 commit comments