Commit50fa688

committed

Fix some comments related to logical repslot advancing

confirmed_flush is part of a replication slot's information, but notconfirmed_lsn.Author: Kyotaro HoriguchiDiscussion:https://postgr.es/m/20191226.175919.17237335658671970.horikyota.ntt@gmail.comBackpatch-through: 11

1 parent8052aaf commit50fa688Copy full SHA for 50fa688

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -379,8 +379,8 @@ pg_physical_replication_slot_advance(XLogRecPtr moveto)`
`379`	`379`	`/*`
`380`	`380`	`* Helper function for advancing our logical replication slot forward.`
`381`	`381`	`*`
`382`		`- * The slot's restart_lsn is used as start point for reading records,`
`383`		`- *while confirmed_lsn is used as base point for the decoding context.`
	`382`	`+ * The slot's restart_lsn is used as start point for reading records, while`
	`383`	`+ *confirmed_flush is used as base point for the decoding context.`
`384`	`384`	`*`
`385`	`385`	`* We cannot just do LogicalConfirmReceivedLocation to update confirmed_flush,`
`386`	`386`	`* because we need to digest WAL to advance restart_lsn allowing to recycle`
`@@ -550,8 +550,8 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS)`
`550`	`550`	`/*`
`551`	`551`	`* Check if the slot is not moving backwards. Physical slots rely simply`
`552`	`552`	`* on restart_lsn as a minimum point, while logical slots have confirmed`
`553`		`- * consumption up toconfirmed_lsn, meaning that in both cases data older`
`554`		`- * than that is not available anymore.`
	`553`	`+ * consumption up toconfirmed_flush, meaning that in both cases data`
	`554`	`+ *olderthan that is not available anymore.`
`555`	`555`	`*/`
`556`	`556`	`if (OidIsValid(MyReplicationSlot->data.database))`
`557`	`557`	`minlsn=MyReplicationSlot->data.confirmed_flush;`

Comments

(0)