NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit50cd651

committed

Use the correct sizeof() in BufFileLoadBuffer

The sizeof() call should reference buffer.data, because that's thebuffer we're reading data into, not the whole PGAlignedBuffer union.This was introduced by44cac93, which replaced the simple bufferwith a PGAlignedBuffer field.It's benign, because the buffer is the largest field of the union, sothe sizes are the same. But it's easy to trip over this in a patch, sofix and backpatch. Commit44cac93 went into 12, but that's EOL.Backpatch-through: 13Discussion:https://postgr.es/m/928bdab1-6567-449f-98c4-339cd2203b87@vondra.me

1 parent24c5b73 commit50cd651Copy full SHA for 50cd651

File tree

1 file changed

-1

lines changed

src/backend/storage/file
- buffile.c

1 file changed

-1

lines changed

`‎src/backend/storage/file/buffile.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,7 @@ BufFileLoadBuffer(BufFile *file)`
`459`	`459`	`*/`
`460`	`460`	`file->nbytes=FileRead(thisfile,`
`461`	`461`	`file->buffer.data,`
`462`		`-sizeof(file->buffer),`
	`462`	`+sizeof(file->buffer.data),`
`463`	`463`	`file->curOffset,`
`464`	`464`	`WAIT_EVENT_BUFFILE_READ);`
`465`	`465`	`if (file->nbytes<0)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit50cd651

File tree

1 file changed

1 file changed

`‎src/backend/storage/file/buffile.c`

0 commit comments