NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit509da59

committed

Fix use of already freed memory when dumping a database's security label.

pg_dump.c:dumDatabase() called ArchiveEntry() with the results of a aquery that was PQclear()ed a couple lines earlier.Backpatch to 9.2 where security labels for shared objects whereintroduced.

1 parente32cb8d commit509da59Copy full SHA for 509da59

File tree

1 file changed

-5

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-5

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 9 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -2428,25 +2428,29 @@ dumpDatabase(Archive *fout)`
`2428`	`2428`	`dbCatId,0,dbDumpId);`
`2429`	`2429`	`}`
`2430`	`2430`
`2431`		`-PQclear(res);`
`2432`		`-`
`2433`	`2431`	`/* Dump shared security label. */`
`2434`	`2432`	`if (!no_security_labels&&fout->remoteVersion >=90200)`
`2435`	`2433`	`{`
`2436`		`-PQExpBufferseclabelQry=createPQExpBuffer();`
	`2434`	`+PGresult*shres;`
	`2435`	`+PQExpBufferseclabelQry;`
	`2436`	`+`
	`2437`	`+seclabelQry=createPQExpBuffer();`
`2437`	`2438`
`2438`	`2439`	`buildShSecLabelQuery(conn,"pg_database",dbCatId.oid,seclabelQry);`
`2439`		`-res=ExecuteSqlQuery(fout,seclabelQry->data,PGRES_TUPLES_OK);`
	`2440`	`+shres=ExecuteSqlQuery(fout,seclabelQry->data,PGRES_TUPLES_OK);`
`2440`	`2441`	`resetPQExpBuffer(seclabelQry);`
`2441`		`-emitShSecLabels(conn,res,seclabelQry,"DATABASE",datname);`
	`2442`	`+emitShSecLabels(conn,shres,seclabelQry,"DATABASE",datname);`
`2442`	`2443`	`if (strlen(seclabelQry->data))`
`2443`	`2444`	`ArchiveEntry(fout,dbCatId,createDumpId(),datname,NULL,NULL,`
`2444`	`2445`	`dba, false,"SECURITY LABEL",SECTION_NONE,`
`2445`	`2446`	`seclabelQry->data,"",NULL,`
`2446`	`2447`	`&dbDumpId,1,NULL,NULL);`
`2447`	`2448`	`destroyPQExpBuffer(seclabelQry);`
	`2449`	`+PQclear(shres);`
`2448`	`2450`	`}`
`2449`	`2451`
	`2452`	`+PQclear(res);`
	`2453`	`+`
`2450`	`2454`	`destroyPQExpBuffer(dbQry);`
`2451`	`2455`	`destroyPQExpBuffer(delQry);`
`2452`	`2456`	`destroyPQExpBuffer(creaQry);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit509da59

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments