NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit504c717

committed

Fix bug in handling of connections that pg_receivexlog creates.

Previously pg_receivexlog created new connection for WAL streamingeven though another connection which had been established to createor delete the replication slot was being left. This caused the unusedconnection to be left uselessly until pg_receivexlog exited.This bug was introduced by the commitd9f38c7.This patch changes pg_receivexlog so that the connection forthe replication slot is reused for WAL streaming.Andres Freund, slightly modified by me, reviewed by Michael Paquier

1 parent5c38a1d commit504c717Copy full SHA for 504c717

File tree

1 file changed

-1

lines changed

src/bin/pg_basebackup
- pg_receivexlog.c

1 file changed

-1

lines changed

`‎src/bin/pg_basebackup/pg_receivexlog.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,8 @@ StreamLog(void)`
`293`	`293`	`/*`
`294`	`294`	`* Connect in replication mode to the server`
`295`	`295`	`*/`
`296`		`-conn=GetConnection();`
	`296`	`+if (conn==NULL)`
	`297`	`+conn=GetConnection();`
`297`	`298`	`if (!conn)`
`298`	`299`	`/* Error message already written in GetConnection() */`
`299`	`300`	`return;`
`@@ -345,6 +346,7 @@ StreamLog(void)`
`345`	`346`	`fsync_interval);`
`346`	`347`
`347`	`348`	`PQfinish(conn);`
	`349`	`+conn=NULL;`
`348`	`350`	`}`
`349`	`351`
`350`	`352`	`/*`
`@@ -591,6 +593,11 @@ main(int argc, char **argv)`
`591`	`593`	`disconnect_and_exit(1);`
`592`	`594`	`}`
`593`	`595`
	`596`	`+/*`
	`597`	`+ * Don't close the connection here so that subsequent StreamLog()`
	`598`	`+ * can reuse it.`
	`599`	`+ */`
	`600`	`+`
`594`	`601`	`while (true)`
`595`	`602`	`{`
`596`	`603`	`StreamLog();`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit504c717

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/pg_receivexlog.c`

0 commit comments