NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit500256d

committed

Fix pg_amcheck --skip option parameter handling

The skip options set for all-visible and all-frozen were incorrectas they used space rather than hyphen, causing a syntax error wheninvoked. Also, the option for not skipping any pages at all, none,was documented but not implemented.Backpatch through 14 where pg_amcheck was introduced.Bug: #17149Reported-by: Chen Jiaoqian <chenjq.jy@fujitsu.com>Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>Discussion:https://postgr.es/m/17149-5918ea748da36b15@postgresql.orgBackpatch-through: 14

1 parent6b71c92 commit500256dCopy full SHA for 500256d

File tree

1 file changed

-2

lines changed

src/bin/pg_amcheck
- pg_amcheck.c

1 file changed

-2

lines changed

`‎src/bin/pg_amcheck/pg_amcheck.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -395,9 +395,11 @@ main(int argc, char *argv[])`
`395`	`395`	`break;`
`396`	`396`	`case6:`
`397`	`397`	`if (pg_strcasecmp(optarg,"all-visible")==0)`
`398`		`-opts.skip="allvisible";`
	`398`	`+opts.skip="all-visible";`
`399`	`399`	`elseif (pg_strcasecmp(optarg,"all-frozen")==0)`
`400`		`-opts.skip="all frozen";`
	`400`	`+opts.skip="all-frozen";`
	`401`	`+elseif (pg_strcasecmp(optarg,"none")==0)`
	`402`	`+opts.skip="none";`
`401`	`403`	`else`
`402`	`404`	`{`
`403`	`405`	`pg_log_error("invalid argument for option %s","--skip");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit500256d

File tree

1 file changed

1 file changed

`‎src/bin/pg_amcheck/pg_amcheck.c`

0 commit comments