forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit4f52fd3
committed
Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro.
This turns out not to be as harmless as I thought: MSVC will complainif it sees an "extern" declaration without PGDLLEXPORT and then one with.(Seems fairly silly, given that this can be changed after the fact by thelinker, but there you have it.) Therefore, contrib modules that haveextern's for V1 functions in header files are falling over in thebuildfarm, since none of those externs are marked PGDLLEXPORT.We might or might not conclude that we're willing to plaster thosedeclarations with PGDLLEXPORT in HEAD, but in any case there's no way we'regoing to ship this change in the back branches. Third-party authors wouldnot thank us for breaking their code in a minor release. Hence, revertthe addition of PGDLLEXPORT (but let's keep the extra info in the comment).If we do the other changes we can revert this commit in HEAD.Per buildfarm.1 parentc0a3b21 commit4f52fd3
1 file changed
+4
-3
lines changedLines changed: 4 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
350 | 350 |
| |
351 | 351 |
| |
352 | 352 |
| |
353 |
| - | |
354 |
| - | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
355 | 356 |
| |
356 | 357 |
| |
357 |
| - | |
| 358 | + | |
358 | 359 |
| |
359 | 360 |
| |
360 | 361 |
| |
|
0 commit comments
Comments
(0)