Commit4f49b3f

committed

Trust signalfd on illumos, again.

Commit3ab4fc5 avoided choosing signalfd by default on illumos, becauseit triggered kernel panics. That was fixed, so we can remove a kludgefrom our code. Users/packagers can still override the default choice atcompile time if desired, and we'll leave the back-branches unchanged sothey keep choosing self-pipe by default, but we'll default to signalfd(like we do for Linux) in 17. Fixed kernels should be everywhere by thetime 17 ships.The illumos issues were: *https://www.illumos.org/issues/13700 *https://www.illumos.org/issues/14892Discussion:https://postgr.es/m/CA+hUKG+NK-K_G_i1H3OpDTwYPEsiwQi_jw58PGcW2H+-N2eVCA@mail.gmail.com

1 parent01d56ee commit4f49b3fCopy full SHA for 4f49b3f

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -86,14 +86,12 @@`
`86`	`86`
`87`	`87`	`/*`
`88`	`88`	`* By default, we use a self-pipe with poll() and a signalfd with epoll(), if`
`89`		`- * available. We avoid signalfd on illumos for now based on problem reports.`
`90`		`- * For testing the choice can also be manually specified.`
	`89`	`+ * available. For testing the choice can also be manually specified.`
`91`	`90`	`*/`
`92`	`91`	`#if defined(WAIT_USE_POLL)\|\| defined(WAIT_USE_EPOLL)`
`93`	`92`	`#if defined(WAIT_USE_SELF_PIPE)\|\| defined(WAIT_USE_SIGNALFD)`
`94`	`93`	`/* don't overwrite manual choice */`
`95`		`-#elif defined(WAIT_USE_EPOLL)&& defined(HAVE_SYS_SIGNALFD_H)&& \`
`96`		`-!defined(__illumos__)`
	`94`	`+#elif defined(WAIT_USE_EPOLL)&& defined(HAVE_SYS_SIGNALFD_H)`
`97`	`95`	`#defineWAIT_USE_SIGNALFD`
`98`	`96`	`#else`
`99`	`97`	`#defineWAIT_USE_SELF_PIPE`

Comments

(0)