NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4eca51d

committed

Don't leak malloc'd error string in libpqrcv_check_conninfo().

We leaked the error report from PQconninfoParse, when there wasone. It seems unlikely that real usage patterns would repeatthe failure often enough to create serious bloat, but let'sback-patch anyway to keep the code similar in all branches.Found via valgrind testing.Back-patch to v10 where this code was added.Discussion:https://postgr.es/m/3816764.1616104288@sss.pgh.pa.us

1 parentfc552f8 commit4eca51dCopy full SHA for 4eca51d

File tree

1 file changed

-1

lines changed

src/backend/replication/libpqwalreceiver
- libpqwalreceiver.c

1 file changed

-1

lines changed

`‎src/backend/replication/libpqwalreceiver/libpqwalreceiver.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -244,9 +244,15 @@ libpqrcv_check_conninfo(const char *conninfo)`
`244`	`244`
`245`	`245`	`opts=PQconninfoParse(conninfo,&err);`
`246`	`246`	`if (opts==NULL)`
	`247`	`+{`
	`248`	`+/* The error string is malloc'd, so we must free it explicitly */`
	`249`	`+char*errcopy=err ?pstrdup(err) :"out of memory";`
	`250`	`+`
	`251`	`+PQfreemem(err);`
`247`	`252`	`ereport(ERROR,`
`248`	`253`	`(errcode(ERRCODE_SYNTAX_ERROR),`
`249`		`-errmsg("invalid connection string syntax: %s",err)));`
	`254`	`+errmsg("invalid connection string syntax: %s",errcopy)));`
	`255`	`+}`
`250`	`256`
`251`	`257`	`PQconninfoFree(opts);`
`252`	`258`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4eca51d

File tree

1 file changed

1 file changed

`‎src/backend/replication/libpqwalreceiver/libpqwalreceiver.c`

0 commit comments