forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit4e15387
committed
Try to improve readability of recovery/t/009_twophase.pl test.
The original coding here was very confusing, because it named thetwo servers it set up "master" and "slave" even though it swappedtheir replication roles multiple times. At any given point in thescript it was very unobvious whether "$node_master" actually referredto the server named "master" or the other one. Instead, pick arbitrarynames for the two servers --- I used "london" and "paris" --- anddistinguish those permanent names from the nonce references $cur_masterand $cur_slave. Add logging to help distinguish which is which atany given point. Also, use distinct data and transaction names tomake all the prepared transactions easily distinguishable in thepostmaster logs. (There was one place where we intentionally testedthat the server could cope with re-use of a transaction name, butit seems like one place is sufficient for that purpose.)Also, add checks at the end to make sure that all the transactionsthat were supposed to be committed did survive.Discussion:https://postgr.es/m/28238.1499010855@sss.pgh.pa.us1 parentde3de0a commit4e15387
1 file changed
+225
-128
lines changed0 commit comments
Comments
(0)