Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit4d916dd

Browse files
committed
Stabilize test of BRIN parallel create
The test for parallel create of BRIN indexes added by commit8225c2fhappens to be unstable - a background transaction (e.g. auto-analyze)may hold back global xmin for the initial VACUUM / CREATE INDEX. If thecleanup happens before the next CREATE INDEX, the indexes will not beexactly the same.This is the same issue ase2933a6, so fix it the same way by makingthe table TEMPORARY, which uses an up-to-date cutoff xmin that is notheld back by other processes.Reported by Alexander Lakhin, who also suggested the fix.Author: Alexander LakhinDiscussion:https://postgr.es/m/b58901cd-a7cc-29c6-e2b1-e3d7317c3c69@gmail.comDiscussion:https://postgr.es/m/2892135.1668976646@sss.pgh.pa.us
1 parent03107b4 commit4d916dd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

‎contrib/pageinspect/expected/brin.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ SELECT (COUNT(*) = (SELECT relpages FROM pg_class WHERE relname = 'test2')) AS r
109109
DROP TABLE test1;
110110
DROP TABLE test2;
111111
-- Test that parallel index build produces the same BRIN index as serial build.
112-
CREATE TABLE brin_parallel_test (a int, b text, c bigint) WITH (fillfactor=40);
112+
CREATETEMPORARYTABLE brin_parallel_test (a int, b text, c bigint) WITH (fillfactor=40);
113113
-- Generate a table with a mix of NULLs and non-NULL values (and data suitable
114114
-- for the different opclasses we build later).
115115
INSERT INTO brin_parallel_test

‎contrib/pageinspect/sql/brin.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ DROP TABLE test1;
5656
DROPTABLE test2;
5757

5858
-- Test that parallel index build produces the same BRIN index as serial build.
59-
CREATETABLEbrin_parallel_test (aint, btext, cbigint) WITH (fillfactor=40);
59+
CREATETEMPORARYTABLE brin_parallel_test (aint, btext, cbigint) WITH (fillfactor=40);
6060

6161
-- Generate a table with a mix of NULLs and non-NULL values (and data suitable
6262
-- for the different opclasses we build later).

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp