Commit4d5105a

committed

Improve error message for pg_create_subscription.

c3afe8c updated this error message, but it didn't use the newstyle established inde4d456.Reviewed-by: Tom LaneDiscussion:https://postgr.es/m/20230512203721.GA2644063%40nathanxps13.home

1 parent51b2c08 commit4d5105aCopy full SHA for 4d5105a

File tree

-2

lines changed

src
- backend/commands
  - subscriptioncmds.c
- test/regress/expected
  - subscription.out

-2

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -611,7 +611,9 @@ CreateSubscription(ParseState pstate, CreateSubscriptionStmt stmt,`
`611`	`611`	`if (!has_privs_of_role(owner,ROLE_PG_CREATE_SUBSCRIPTION))`
`612`	`612`	`ereport(ERROR,`
`613`	`613`	`(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),`
`614`		`-errmsg("must have privileges of pg_create_subscription to create subscriptions")));`
	`614`	`+errmsg("permission denied to create subscription"),`
	`615`	`+errdetail("Only roles with privileges of the \"%s\" role may create subscriptions.",`
	`616`	`+"pg_create_subscription")));`
`615`	`617`
`616`	`618`	`/*`
`617`	`619`	`* Since a subscription is a database object, we also check for CREATE`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,8 @@ ERROR: subscription "regress_testsub" already exists`
`79`	`79`	`-- fail - must be superuser`
`80`	`80`	`SET SESSION AUTHORIZATION 'regress_subscription_user2';`
`81`	`81`	`CREATE SUBSCRIPTION regress_testsub2 CONNECTION 'dbname=regress_doesnotexist' PUBLICATION foo WITH (connect = false);`
`82`		`-ERROR: must have privileges of pg_create_subscription to create subscriptions`
	`82`	`+ERROR: permission denied to create subscription`
	`83`	`+DETAIL: Only roles with privileges of the "pg_create_subscription" role may create subscriptions.`
`83`	`84`	`SET SESSION AUTHORIZATION 'regress_subscription_user';`
`84`	`85`	`-- fail - invalid option combinations`
`85`	`86`	`CREATE SUBSCRIPTION regress_testsub2 CONNECTION 'dbname=regress_doesnotexist' PUBLICATION testpub WITH (connect = false, copy_data = true);`

Comments

(0)