NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4d4c891

committed

Initialize replication_slot_catalog_xmin in procarray

Although not confirmed and probably rare, if the newly allocated memoryis not already zero, this could possibly have caused some problems.Also reorder the initializations slightly so they match the order of thestruct definition.Author: Wong, Yi Wen <yiwong@amazon.com>Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>

1 parent0a2d43d commit4d4c891Copy full SHA for 4d4c891

File tree

1 file changed

-1

lines changed

src/backend/storage/ipc
- procarray.c

1 file changed

-1

lines changed

`‎src/backend/storage/ipc/procarray.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -237,13 +237,14 @@ CreateSharedProcArray(void)`
`237`	`237`	`*/`
`238`	`238`	`procArray->numProcs=0;`
`239`	`239`	`procArray->maxProcs=PROCARRAY_MAXPROCS;`
`240`		`-procArray->replication_slot_xmin=InvalidTransactionId;`
`241`	`240`	`procArray->maxKnownAssignedXids=TOTAL_MAX_CACHED_SUBXIDS;`
`242`	`241`	`procArray->numKnownAssignedXids=0;`
`243`	`242`	`procArray->tailKnownAssignedXids=0;`
`244`	`243`	`procArray->headKnownAssignedXids=0;`
`245`	`244`	`SpinLockInit(&procArray->known_assigned_xids_lck);`
`246`	`245`	`procArray->lastOverflowedXid=InvalidTransactionId;`
	`246`	`+procArray->replication_slot_xmin=InvalidTransactionId;`
	`247`	`+procArray->replication_slot_catalog_xmin=InvalidTransactionId;`
`247`	`248`	`}`
`248`	`249`
`249`	`250`	`allProcs=ProcGlobal->allProcs;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4d4c891

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/procarray.c`

0 commit comments