Commit4cd8717

committed

Improve a couple of sql/json error messages

Fix the grammar in two, and add a hint to one.

1 parentfcdb35c commit4cd8717Copy full SHA for 4cd8717

File tree

+10

-6

lines changed

src
- backend/parser
  - parse_expr.c
- test/regress/expected
  - json_sqljson.out

+10

-6

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4456,7 +4456,7 @@ transformJsonFuncExpr(ParseState pstate, JsonFuncExpr func)`
`4456`	`4456`	`if (jsexpr->returning->typid!=JSONBOID)`
`4457`	`4457`	`ereport(ERROR,`
`4458`	`4458`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`4459`		`-errmsg("JSON_TABLE() is not yet implemented for json type"),`
	`4459`	`+errmsg("JSON_TABLE() is not yet implemented forthejson type"),`
`4460`	`4460`	`errhint("Try casting the argument to jsonb"),`
`4461`	`4461`	`parser_errposition(pstate,func->location)));`
`4462`	`4462`
`@@ -4466,7 +4466,8 @@ transformJsonFuncExpr(ParseState pstate, JsonFuncExpr func)`
`4466`	`4466`	`if (exprType(contextItemExpr)!=JSONBOID)`
`4467`	`4467`	`ereport(ERROR,`
`4468`	`4468`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`4469`		`-errmsg("%s() is not yet implemented for json type",func_name),`
	`4469`	`+errmsg("%s() is not yet implemented for the json type",func_name),`
	`4470`	`+errhint("Try casting the argument to jsonb"),`
`4470`	`4471`	`parser_errposition(pstate,func->location)));`
`4471`	`4472`
`4472`	`4473`	`return (Node*)jsexpr;`

Lines changed: 7 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,21 +1,24 @@`
`1`	`1`	`-- JSON_EXISTS`
`2`	`2`	`SELECT JSON_EXISTS(NULL FORMAT JSON, '$');`
`3`		`-ERROR: JSON_EXISTS() is not yet implemented for json type`
	`3`	`+ERROR: JSON_EXISTS() is not yet implemented forthejson type`
`4`	`4`	`LINE 1: SELECT JSON_EXISTS(NULL FORMAT JSON, '$');`
`5`	`5`	`^`
	`6`	`+HINT: Try casting the argument to jsonb`
`6`	`7`	`-- JSON_VALUE`
`7`	`8`	`SELECT JSON_VALUE(NULL FORMAT JSON, '$');`
`8`		`-ERROR: JSON_VALUE() is not yet implemented for json type`
	`9`	`+ERROR: JSON_VALUE() is not yet implemented forthejson type`
`9`	`10`	`LINE 1: SELECT JSON_VALUE(NULL FORMAT JSON, '$');`
`10`	`11`	`^`
	`12`	`+HINT: Try casting the argument to jsonb`
`11`	`13`	`-- JSON_QUERY`
`12`	`14`	`SELECT JSON_QUERY(NULL FORMAT JSON, '$');`
`13`		`-ERROR: JSON_QUERY() is not yet implemented for json type`
	`15`	`+ERROR: JSON_QUERY() is not yet implemented forthejson type`
`14`	`16`	`LINE 1: SELECT JSON_QUERY(NULL FORMAT JSON, '$');`
`15`	`17`	`^`
	`18`	`+HINT: Try casting the argument to jsonb`
`16`	`19`	`-- JSON_TABLE`
`17`	`20`	`SELECT * FROM JSON_TABLE(NULL FORMAT JSON, '$' COLUMNS (foo text));`
`18`		`-ERROR: JSON_TABLE() is not yet implemented for json type`
	`21`	`+ERROR: JSON_TABLE() is not yet implemented forthejson type`
`19`	`22`	`LINE 1: SELECT * FROM JSON_TABLE(NULL FORMAT JSON, '$' COLUMNS (foo ...`
`20`	`23`	`^`
`21`	`24`	`HINT: Try casting the argument to jsonb`

Comments

(0)