NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4cbecda

committed

Avoid wholesale autovacuuming when autovacuum is nominally off.

When autovacuum is nominally off, we will still launch autovac workersto vacuum tables that are at risk of XID wraparound. But after we'd donethat, an autovac worker would proceed to autovacuum every table in thetargeted database, if they meet the usual thresholds for autovacuuming.This is at best pretty unexpected; at worst it delays response to thewraparound threat. Fix it so that if autovacuum is nominally off, we*only* do forced vacuums and not any other work.Per gripe from Andrey Zhidenkov. This has been like this all along,so back-patch to all supported branches.

1 parent05c0059 commit4cbecdaCopy full SHA for 4cbecda

File tree

1 file changed

-2

lines changed

src/backend/postmaster
- autovacuum.c

1 file changed

-2

lines changed

`‎src/backend/postmaster/autovacuum.c`

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2726,14 +2726,21 @@ relation_needs_vacanalyze(Oid relid,`
`2726`	`2726`	`*wraparound=force_vacuum;`
`2727`	`2727`
`2728`	`2728`	`/* User disabled it in pg_class.reloptions? (But ignore if at risk) */`
`2729`		`-if (!force_vacuum&& !av_enabled)`
	`2729`	`+if (!av_enabled&& !force_vacuum)`
`2730`	`2730`	`{`
`2731`	`2731`	`*doanalyze= false;`
`2732`	`2732`	`*dovacuum= false;`
`2733`	`2733`	`return;`
`2734`	`2734`	`}`
`2735`	`2735`
`2736`		`-if (PointerIsValid(tabentry))`
	`2736`	`+/*`
	`2737`	`+ * If we found the table in the stats hash, and autovacuum is currently`
	`2738`	`+ * enabled, make a threshold-based decision whether to vacuum and/or`
	`2739`	`+ * analyze. If autovacuum is currently disabled, we must be here for`
	`2740`	`+ * anti-wraparound vacuuming only, so don't vacuum (or analyze) anything`
	`2741`	`+ * that's not being forced.`
	`2742`	`+ */`
	`2743`	`+if (PointerIsValid(tabentry)&&AutoVacuumingActive())`
`2737`	`2744`	`{`
`2738`	`2745`	`reltuples=classForm->reltuples;`
`2739`	`2746`	`vactuples=tabentry->n_dead_tuples;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4cbecda

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/autovacuum.c`

0 commit comments