NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4ca50e0

committed

Avoid inconsistent type declaration

Clang 3.3 correctly complains that a variable of type enumMultiXactStatus cannot hold a value of -1, which makes sense. Changethe declared type of the variable to int instead, and apply casting asnecessary to avoid the warning.Per notice from Andres Freund

1 parent81166a2 commit4ca50e0Copy full SHA for 4ca50e0

File tree

1 file changed

-4

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-4

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 7 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -116,12 +116,15 @@ static bool ConditionalMultiXactIdWait(MultiXactId multi,`
`116`	`116`	`* update them). This table (and the macros below) helps us determine the`
`117`	`117`	`* heavyweight lock mode and MultiXactStatus values to use for any particular`
`118`	`118`	`* tuple lock strength.`
	`119`	`+ *`
	`120`	`+ * Don't look at lockstatus/updstatus directly! Use get_mxact_status_for_lock`
	`121`	`+ * instead.`
`119`	`122`	`*/`
`120`	`123`	`staticconststruct`
`121`	`124`	`{`
`122`	`125`	`LOCKMODEhwlock;`
`123`		`-MultiXactStatuslockstatus;`
`124`		`-MultiXactStatusupdstatus;`
	`126`	`+intlockstatus;`
	`127`	`+intupdstatus;`
`125`	`128`	`}`
`126`	`129`
`127`	`130`	`tupleLockExtraInfo[MaxLockTupleMode+1]=`
`@@ -3847,7 +3850,7 @@ simple_heap_update(Relation relation, ItemPointer otid, HeapTuple tup)`
`3847`	`3850`	`staticMultiXactStatus`
`3848`	`3851`	`get_mxact_status_for_lock(LockTupleModemode,boolis_update)`
`3849`	`3852`	`{`
`3850`		`-MultiXactStatusretval;`
	`3853`	`+intretval;`
`3851`	`3854`
`3852`	`3855`	`if (is_update)`
`3853`	`3856`	`retval=tupleLockExtraInfo[mode].updstatus;`
`@@ -3858,7 +3861,7 @@ get_mxact_status_for_lock(LockTupleMode mode, bool is_update)`
`3858`	`3861`	`elog(ERROR,"invalid lock tuple mode %d/%s",mode,`
`3859`	`3862`	`is_update ?"true" :"false");`
`3860`	`3863`
`3861`		`-returnretval;`
	`3864`	`+return(MultiXactStatus)retval;`
`3862`	`3865`	`}`
`3863`	`3866`
`3864`	`3867`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4ca50e0

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments