Commit4ca28eb

committed

I just discovered, that there is missing a const when passing a buffer

to PQescapeBytea and PQunescapeBytea. I fixed it and tried to create ausable diff (I'm not so familar to diff).Tommi M?kitalo

1 parent3eabc44 commit4ca28ebCopy full SHA for 4ca28eb

File tree

+11

-11

lines changed

+11

-11

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`<!--`
`2`		`-$Header: /cvsroot/pgsql/doc/src/sgml/libpq.sgml,v 1.99 2002/11/08 05:03:11 momjian Exp $`
	`2`	`+$Header: /cvsroot/pgsql/doc/src/sgml/libpq.sgml,v 1.100 2002/11/10 00:14:22 momjian Exp $`
`3`	`3`	`-->`
`4`	`4`
`5`	`5`	`<chapter id="libpq">`
`@@ -926,7 +926,7 @@ strings overlap.`
`926`	`926`	`<function>PQescapeBytea</function>`
`927`	`927`	`Escapes a binary string (<type>bytea</type> type) for use within an SQL query.`
`928`	`928`	`<synopsis>`
`929`		`- unsigned char PQescapeBytea(unsigned char from,`
	`929`	`+ unsigned char PQescapeBytea(constunsigned char from,`
`930`	`930`	`size_t from_length,`
`931`	`931`	`size_t *to_length);`
`932`	`932`	`</synopsis>`
`@@ -970,7 +970,7 @@ strings overlap.`
`970`	`970`	`Converts an escaped string representation of binary data into binary`
`971`	`971`	`data - the reverse of <function>PQescapeBytea</function>.`
`972`	`972`	`<synopsis>`
`973`		`- unsigned char PQunescapeBytea(unsigned char from, size_t *to_length);`
	`973`	`+ unsigned char PQunescapeBytea(constunsigned char from, size_t *to_length);`
`974`	`974`	`</synopsis>`
`975`	`975`
`976`	`976`	`The <parameter>from</parameter> parameter points to an escaped string`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-exec.c,v 1.122 2002/09/04 20:31:47 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-exec.c,v 1.123 2002/11/10 00:14:22 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -118,9 +118,9 @@ PQescapeString(char to, const char from, size_t length)`
`118`	`118`	`*anything >= 0x80 ---> \\ooo (where ooo is an octal expression)`
`119`	`119`	`*/`
`120`	`120`	`unsignedchar*`
`121`		`-PQescapeBytea(unsignedcharbintext,size_tbinlen,size_tbytealen)`
	`121`	`+PQescapeBytea(constunsignedcharbintext,size_tbinlen,size_tbytealen)`
`122`	`122`	`{`
`123`		`-unsignedchar*vp;`
	`123`	`+constunsignedchar*vp;`
`124`	`124`	`unsignedchar*rp;`
`125`	`125`	`unsignedchar*result;`
`126`	`126`	`size_ti;`
`@@ -202,12 +202,12 @@ PQescapeBytea(unsigned char bintext, size_t binlen, size_t bytealen)`
`202`	`202`	`*6\\`
`203`	`203`	`*/`
`204`	`204`	`unsignedchar*`
`205`		`-PQunescapeBytea(unsignedcharstrtext,size_tretbuflen)`
	`205`	`+PQunescapeBytea(constunsignedcharstrtext,size_tretbuflen)`
`206`	`206`	`{`
`207`	`207`	`size_tbuflen;`
`208`	`208`	`unsignedchar*buffer,`
`209`		`-*sp,`
`210`	`209`	`*bp;`
	`210`	`+constunsignedchar*sp;`
`211`	`211`	`unsignedintstate=0;`
`212`	`212`
`213`	`213`	`if (strtext==NULL)`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $Id: libpq-fe.h,v 1.86 2002/09/04 20:31:47 momjian Exp $`
	`10`	`+ * $Id: libpq-fe.h,v 1.87 2002/11/10 00:14:22 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -249,9 +249,9 @@ extern PQnoticeProcessor PQsetNoticeProcessor(PGconn *conn,`
`249`	`249`
`250`	`250`	`/* Quoting strings before inclusion in queries. */`
`251`	`251`	`externsize_tPQescapeString(charto,constcharfrom,size_tlength);`
`252`		`-externunsignedcharPQescapeBytea(unsignedcharbintext,size_tbinlen,`
	`252`	`+externunsignedcharPQescapeBytea(constunsignedcharbintext,size_tbinlen,`
`253`	`253`	`size_t*bytealen);`
`254`		`-externunsignedcharPQunescapeBytea(unsignedcharstrtext,`
	`254`	`+externunsignedcharPQunescapeBytea(constunsignedcharstrtext,`
`255`	`255`	`size_t*retbuflen);`
`256`	`256`
`257`	`257`

Comments

(0)