Commit4c92282

committed

Remove NULL dereference from RenameRelationInternal().

Defect in last week's commitaac2c9b,per Coverity. Reaching this would need catalog corruption. Back-patchto v12, like that commit.

1 parent0a709c4 commit4c92282Copy full SHA for 4c92282

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3990,9 +3990,9 @@ RenameRelationInternal(Oid myrelid, const char *newrelname, bool is_internal, bo`
`3990`	`3990`	`relrelation = table_open(RelationRelationId, RowExclusiveLock);`
`3991`	`3991`
`3992`	`3992`	`reltup = SearchSysCacheLockedCopy1(RELOID, ObjectIdGetDatum(myrelid));`
`3993`		`-otid = reltup->t_self;`
`3994`	`3993`	`if (!HeapTupleIsValid(reltup))/* shouldn't happen */`
`3995`	`3994`	`elog(ERROR, "cache lookup failed for relation %u", myrelid);`
	`3995`	`+otid = reltup->t_self;`
`3996`	`3996`	`relform = (Form_pg_class) GETSTRUCT(reltup);`
`3997`	`3997`
`3998`	`3998`	`if (get_relname_relid(newrelname, namespaceId) != InvalidOid)`

Comments

(0)