Commit4c3b59a

committed

Fix failure when a shared tidbitmap has only one page.

Commit98e6e89 made inadequateprovision for the case of a single-page shared tidbitmap. Itallocate space for a shared PagetableEntry, but failed toinitialize it.Report by Thomas Munro. Patch by Dilip Kumar, with some commentchanges by me.Discussion:http://postgr.es/m/CAEepm=19Cmnfbi-j2Bw-a6yGPeHE1OVhKvvKz9bRBTJGKfGHMA@mail.gmail.com

1 parent28b0478 commit4c3b59aCopy full SHA for 4c3b59a

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -866,12 +866,14 @@ tbm_prepare_shared_iterate(TIDBitmap *tbm)`
`866`	`866`	`elseif (tbm->status==TBM_ONE_PAGE)`
`867`	`867`	`{`
`868`	`868`	`/*`
`869`		`- * In one page mode allocate the space for one pagetable entry and`
`870`		`- * directly store its index i.e. 0 in page array`
	`869`	`+ * In one page mode allocate the space for one pagetable entry,`
	`870`	`+ * initialize it, and directly store its index (i.e. 0) in the`
	`871`	`+ * page array.`
`871`	`872`	`*/`
`872`	`873`	`tbm->dsapagetable=dsa_allocate(tbm->dsa,sizeof(PTEntryArray)+`
`873`	`874`	`sizeof(PagetableEntry));`
`874`	`875`	`ptbase=dsa_get_address(tbm->dsa,tbm->dsapagetable);`
	`876`	`+memcpy(ptbase->ptentry,&tbm->entry1,sizeof(PagetableEntry));`
`875`	`877`	`ptpages->index[0]=0;`
`876`	`878`	`}`
`877`	`879`

Comments

(0)