NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4c34788

Amit Kapila

committed

Log new catalog xmin candidate in LogicalIncreaseXminForSlot().

Similar to LogicalIncreaseRestartDecodingForSlot() add a debug message toLogicalIncreaseXminForSlot() reporting a new catalog_xmin candidate.This just adds additional diagnostic information during logical decoding thatcan aid debugging.Author: Ashutosh BapatReviewed-by: Masahiko Sawada, Amit KapilaDiscussion:https://postgr.es/m/CAExHW5usQWbiUz0hHOCu5twS1O9DvpcPojf6sor=8q--VUuMbA@mail.gmail.com

1 parentbd5846e commit4c34788Copy full SHA for 4c34788

File tree

1 file changed

+11

-0

lines changed

src/backend/replication/logical
- logical.c

1 file changed

+11

-0

lines changed

`‎src/backend/replication/logical/logical.c‎`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1565,6 +1565,7 @@ LogicalIncreaseXminForSlot(XLogRecPtr current_lsn, TransactionId xmin)`
`1565`	`1565`	`{`
`1566`	`1566`	`boolupdated_xmin= false;`
`1567`	`1567`	`ReplicationSlot*slot;`
	`1568`	`+boolgot_new_xmin= false;`
`1568`	`1569`
`1569`	`1570`	`slot=MyReplicationSlot;`
`1570`	`1571`
`@@ -1602,9 +1603,19 @@ LogicalIncreaseXminForSlot(XLogRecPtr current_lsn, TransactionId xmin)`
`1602`	`1603`	`{`
`1603`	`1604`	`slot->candidate_catalog_xmin=xmin;`
`1604`	`1605`	`slot->candidate_xmin_lsn=current_lsn;`
	`1606`	`+`
	`1607`	`+/*`
	`1608`	`+ * Log new xmin at an appropriate log level after releasing the`
	`1609`	`+ * spinlock.`
	`1610`	`+ */`
	`1611`	`+got_new_xmin= true;`
`1605`	`1612`	`}`
`1606`	`1613`	`SpinLockRelease(&slot->mutex);`
`1607`	`1614`
	`1615`	`+if (got_new_xmin)`
	`1616`	`+elog(DEBUG1,"got new catalog xmin %u at %X/%X",xmin,`
	`1617`	`+LSN_FORMAT_ARGS(current_lsn));`
	`1618`	`+`
`1608`	`1619`	`/* candidate already valid with the current flush position, apply */`
`1609`	`1620`	`if (updated_xmin)`
`1610`	`1621`	`LogicalConfirmReceivedLocation(slot->data.confirmed_flush);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4c34788

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/logical.c‎`

0 commit comments