NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4b8860e

committed

Fix create_scan_plan's handling of sortgrouprefs for physical tlists.

We should only run apply_pathtarget_labeling_to_tlist if CP_LABEL_TLISTwas specified, because only in that case has use_physical_tlist checkedthat the labeling will succeed; otherwise we may get an "ORDER/GROUP BYexpression not found in targetlist" error. (This subsumes the previoustest about gating_clauses, because we reset "flags" to zero earlierif there are gating clauses to apply.)The only known case in which a failure can occur is with a ProjectSetpath directly atop a table scan path, although it seems likely that thereare other cases or will be such in future. This means that the failureis currently only visible in the v10 branch: 9.6 didn't have ProjectSet,while in v11 and HEAD, apply_scanjoin_target_to_paths for some weirdreason is using create_projection_path not apply_projection_to_path,masking the problem because there's a ProjectionPath in between.Nonetheless this code is clearly wrong on its own terms, so back-patchto 9.6 where this logic was introduced.Per report from Regina Obe.Discussion:https://postgr.es/m/001501d40f88$75186950$5f493bf0$@pcorp.us

1 parentd93c056 commit4b8860eCopy full SHA for 4b8860e

File tree

1 file changed

-4

lines changed

src/backend/optimizer/plan
- createplan.c

1 file changed

-4

lines changed

`‎src/backend/optimizer/plan/createplan.c‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -546,10 +546,10 @@ create_scan_plan(PlannerInfo root, Path best_path, int flags)`
`546`	`546`	`tlist=copyObject(((IndexPath*)best_path)->indexinfo->indextlist);`
`547`	`547`
`548`	`548`	`/*`
`549`		`- * Transferanysortgroupref data to the replacement tlist,unless`
`550`		`- *we don't care because the gating Resultwillhandle it.`
	`549`	`+ * Transfer sortgroupref data to the replacement tlist,if`
	`550`	`+ *requested (use_physical_tlist checked that thiswillwork).`
`551`	`551`	`*/`
`552`		`-if (!gating_clauses)`
	`552`	`+if (flags&CP_LABEL_TLIST)`
`553`	`553`	`apply_pathtarget_labeling_to_tlist(tlist,best_path->pathtarget);`
`554`	`554`	`}`
`555`	`555`	`else`
`@@ -563,7 +563,7 @@ create_scan_plan(PlannerInfo root, Path best_path, int flags)`
`563`	`563`	`else`
`564`	`564`	`{`
`565`	`565`	`/* As above, transfer sortgroupref data to replacement tlist */`
`566`		`-if (!gating_clauses)`
	`566`	`+if (flags&CP_LABEL_TLIST)`
`567`	`567`	`apply_pathtarget_labeling_to_tlist(tlist,best_path->pathtarget);`
`568`	`568`	`}`
`569`	`569`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4b8860e

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/createplan.c‎`

0 commit comments