Commit4ad31bb

committed

Remove unused column atttypmod from initial tablesync query

The initial tablesync done by logical replication used a query to fetchthe information of a relation's columns that included atttypmod, but itwas left unused. This was added by7c4f524.Author: Euler TaveiraReviewed-by: Önder Kalacı, Amit Langote, Japin LiDiscussion:https://postgr.es/m/CAHE3wggb715X+mK_DitLXF25B=jE6xyNCH4YOwM860JR7HarGQ@mail.gmail.com

1 parent9522085 commit4ad31bbCopy full SHA for 4ad31bb

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -640,7 +640,7 @@ fetch_remote_table_info(char nspname, char relname,`
`640`	`640`	`StringInfoDatacmd;`
`641`	`641`	`TupleTableSlot*slot;`
`642`	`642`	`OidtableRow[]= {OIDOID,CHAROID,CHAROID};`
`643`		`-OidattrRow[]= {TEXTOID,OIDOID,INT4OID,BOOLOID};`
	`643`	`+OidattrRow[]= {TEXTOID,OIDOID,BOOLOID};`
`644`	`644`	`boolisnull;`
`645`	`645`	`intnatt;`
`646`	`646`
`@@ -685,7 +685,6 @@ fetch_remote_table_info(char nspname, char relname,`
`685`	`685`	`appendStringInfo(&cmd,`
`686`	`686`	`"SELECT a.attname,"`
`687`	`687`	`" a.atttypid,"`
`688`		`-" a.atttypmod,"`
`689`	`688`	`" a.attnum = ANY(i.indkey)"`
`690`	`689`	`" FROM pg_catalog.pg_attribute a"`
`691`	`690`	`" LEFT JOIN pg_catalog.pg_index i"`
`@@ -718,7 +717,7 @@ fetch_remote_table_info(char nspname, char relname,`
`718`	`717`	`Assert(!isnull);`
`719`	`718`	`lrel->atttyps[natt]=DatumGetObjectId(slot_getattr(slot,2,&isnull));`
`720`	`719`	`Assert(!isnull);`
`721`		`-if (DatumGetBool(slot_getattr(slot,4,&isnull)))`
	`720`	`+if (DatumGetBool(slot_getattr(slot,3,&isnull)))`
`722`	`721`	`lrel->attkeys=bms_add_member(lrel->attkeys,natt);`
`723`	`722`
`724`	`723`	`/* Should never happen. */`

Comments

(0)