Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit4aba61b

Browse files
committed
Add some forgotten LSN_FORMAT_ARGS() in xlogreader.c
6f6f284 has introduced a specific macro to make printf()-ing of LSNseasier. This takes care of what looks like the remaining code pathsthat did not get the call.Author: Michael PaquierReviewed-by: Kyotaro Horiguchi, Tom LaneDiscussion:https://postgr.es/m/YIJS9x6K8ruizN7j@paquier.xyz
1 parentbb3ecc8 commit4aba61b

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

‎src/backend/access/transam/xlogreader.c

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -754,8 +754,7 @@ XLogDecodeOneRecord(XLogReaderState *state, bool allow_oversized)
754754
targetRecOff==pageHeaderSize)
755755
{
756756
report_invalid_record(state,"contrecord is requested by %X/%X",
757-
(uint32) (state->DecodeRecPtr >>32),
758-
(uint32)state->DecodeRecPtr);
757+
LSN_FORMAT_ARGS(state->DecodeRecPtr));
759758
gotoerr;
760759
}
761760

@@ -968,10 +967,8 @@ XLogDecodeOneRecord(XLogReaderState *state, bool allow_oversized)
968967
report_invalid_record(
969968
state,
970969
"there is no contrecord flag at %X/%X reading %X/%X",
971-
(uint32) (state->recordContRecPtr >>32),
972-
(uint32)state->recordContRecPtr,
973-
(uint32) (state->DecodeRecPtr >>32),
974-
(uint32)state->DecodeRecPtr);
970+
LSN_FORMAT_ARGS(state->recordContRecPtr),
971+
LSN_FORMAT_ARGS(state->DecodeRecPtr));
975972
gotoerr;
976973
}
977974

@@ -986,10 +983,8 @@ XLogDecodeOneRecord(XLogReaderState *state, bool allow_oversized)
986983
state,
987984
"invalid contrecord length %u at %X/%X reading %X/%X, expected %u",
988985
pageHeader->xlp_rem_len,
989-
(uint32) (state->recordContRecPtr >>32),
990-
(uint32)state->recordContRecPtr,
991-
(uint32) (state->DecodeRecPtr >>32),
992-
(uint32)state->DecodeRecPtr,
986+
LSN_FORMAT_ARGS(state->recordContRecPtr),
987+
LSN_FORMAT_ARGS(state->DecodeRecPtr),
993988
state->recordRemainLen);
994989
gotoerr;
995990
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp