NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4ab7769

Amit Kapila

committed

Fix the SharedFileSetUnregister API.

Commit808e13b introduced a few APIs to extend the existing Buffileinterface. In SharedFileSetDeleteOnProcExit, it tries to delete the listelement while traversing the list with 'foreach' construct which makes thebehavior of list traversal unpredictable.Author: Amit KapilaReviewed-by: Dilip KumarTested-by: Dilip Kumar and Neha SharmaDiscussion:https://postgr.es/m/CAA4eK1JhLatVcQ2OvwA_3s0ih6Hx9+kZbq107cXVsSWWukH7vA@mail.gmail.com

1 parentab3c6d4 commit4ab7769Copy full SHA for 4ab7769

File tree

1 file changed

+10

-6

lines changed

src/backend/storage/file
- sharedfileset.c

1 file changed

+10

-6

lines changed

`‎src/backend/storage/file/sharedfileset.c`

Lines changed: 10 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -266,12 +266,16 @@ SharedFileSetOnDetach(dsm_segment *segment, Datum datum)`
`266`	`266`	`staticvoid`
`267`	`267`	`SharedFileSetDeleteOnProcExit(intstatus,Datumarg)`
`268`	`268`	`{`
`269`		`-ListCell*l;`
`270`		`-`
`271`		`-/* Loop over all the pending shared fileset entry */`
`272`		`-foreach(l,filesetlist)`
	`269`	`+/*`
	`270`	`+ * Remove all the pending shared fileset entries. We don't use foreach() here`
	`271`	`+ * because SharedFileSetDeleteAll will remove the current element in`
	`272`	`+ * filesetlist. Though we have used foreach_delete_current() to remove the`
	`273`	`+ * element from filesetlist it could only fix up the state of one of the`
	`274`	`+ * loops, see SharedFileSetUnregister.`
	`275`	`+ */`
	`276`	`+while (list_length(filesetlist)>0)`
`273`	`277`	`{`
`274`		`-SharedFileSetfileset= (SharedFileSet)lfirst(l);`
	`278`	`+SharedFileSetfileset= (SharedFileSet)linitial(filesetlist);`
`275`	`279`
`276`	`280`	`SharedFileSetDeleteAll(fileset);`
`277`	`281`	`}`
`@@ -301,7 +305,7 @@ SharedFileSetUnregister(SharedFileSet *input_fileset)`
`301`	`305`	`/* Remove the entry from the list */`
`302`	`306`	`if (input_fileset==fileset)`
`303`	`307`	`{`
`304`		`-filesetlist=list_delete_cell(filesetlist,l);`
	`308`	`+filesetlist=foreach_delete_current(filesetlist,l);`
`305`	`309`	`return;`
`306`	`310`	`}`
`307`	`311`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4ab7769

File tree

1 file changed

1 file changed

`‎src/backend/storage/file/sharedfileset.c`

0 commit comments