Commit4ab353c

committed

pg_waldump: Fix small memory leak when rmgr->rm_identify returns NULL.

This got broken in604f795, shortly after rm_identify'sintroduction.Author: Andres FreundDiscussion:https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.deBackpatch: 9.5, where rm_identify was introduced

1 parenteae1ba6 commit4ab353cCopy full SHA for 4ab353c

File tree

-5

lines changed

-5

lines changed

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -533,17 +533,18 @@ XLogDumpDisplayRecord(XLogDumpConfig config, XLogReaderState record)`
`533`	`533`
`534`	`534`	`XLogDumpRecordLen(record,&rec_len,&fpi_len);`
`535`	`535`
`536`		`-id=desc->rm_identify(info);`
`537`		`-if (id==NULL)`
`538`		`-id=psprintf("UNKNOWN (%x)",info& ~XLR_INFO_MASK);`
`539`		`-`
`540`	`536`	`printf("rmgr: %-11s len (rec/tot): %6u/%6u, tx: %10u, lsn: %X/%08X, prev %X/%08X, ",`
`541`	`537`	`desc->rm_name,`
`542`	`538`	`rec_len,XLogRecGetTotalLen(record),`
`543`	`539`	`XLogRecGetXid(record),`
`544`	`540`	`(uint32) (record->ReadRecPtr >>32), (uint32)record->ReadRecPtr,`
`545`	`541`	`(uint32) (xl_prev >>32), (uint32)xl_prev);`
`546`		`-printf("desc: %s ",id);`
	`542`	`+`
	`543`	`+id=desc->rm_identify(info);`
	`544`	`+if (id==NULL)`
	`545`	`+printf("desc: UNKNOWN (%x) ",info& ~XLR_INFO_MASK);`
	`546`	`+else`
	`547`	`+printf("desc: %s ",id);`
`547`	`548`
`548`	`549`	`/* the desc routine will printf the description directly to stdout */`
`549`	`550`	`desc->rm_desc(NULL,record);`

Comments

(0)