Commit4a8283d

committed

Fix handling of volatile expressions in COPY FROM ... WHERE

The checking for calls to volatile functions in the COPY FROM ... WHEREexpression was treating all WHERE clauses as if containing such calls.While that does not produce incorrect results, this disables batchingwhich may result in significant performance regression.Discussion:https://www.postgresql.org/message-id/flat/CALAY4q_DdpWDuB5-Zyi-oTtO2uSk8pmy+dupiRe3AvAc++1imA@mail.gmail.com

1 parent0058810 commit4a8283dCopy full SHA for 4a8283d

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2612,8 +2612,7 @@ CopyFrom(CopyState cstate)`
`2612`	`2612`	`*/`
`2613`	`2613`	`insertMethod=CIM_SINGLE;`
`2614`	`2614`	`}`
`2615`		`-elseif (cstate->whereClause!=NULL\|\|`
`2616`		`-contain_volatile_functions(cstate->whereClause))`
	`2615`	`+elseif (contain_volatile_functions(cstate->whereClause))`
`2617`	`2616`	`{`
`2618`	`2617`	`/*`
`2619`	`2618`	`* Can't support multi-inserts if there are any volatile funcation`

Comments

(0)