NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4a6603c

committed

Fix assertion failure in heap_vacuum_rel

Commit7d71d3d changed resetting the VacuumFailsafeActive flag to anassertion since the flag is reset before starting vacuuming a relation.This however failed to take recursive calls of vacuum_rel() and vacuumof TOAST tables into consideration. Fix by reverting back to resetttingthe flag.Author: Masahiko Sawada <sawada.mshk@gmail.com>Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>Reported-by: John Naylor <john.naylor@enterprisedb.com>Discussion:https://postgr.es/m/CAFBsxsFz=GqaG5Ens5aNgVYoV2Y+pfMUijX0ku+CCkWfALwiqg@mail.gmail.com

1 parentb72f564 commit4a6603cCopy full SHA for 4a6603c

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- vacuumlazy.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/vacuumlazy.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,11 @@ heap_vacuum_rel(Relation rel, VacuumParams *params,`
`389`	`389`	`Assert(params->index_cleanup!=VACOPTVALUE_UNSPECIFIED);`
`390`	`390`	`Assert(params->truncate!=VACOPTVALUE_UNSPECIFIED&&`
`391`	`391`	`params->truncate!=VACOPTVALUE_AUTO);`
`392`		`-Assert(!VacuumFailsafeActive);`
	`392`	`+/*`
	`393`	`+ * While VacuumFailSafeActive is reset to false before calling this, we`
	`394`	`+ * still need to reset it here due to recursive calls.`
	`395`	`+ */`
	`396`	`+VacuumFailsafeActive= false;`
`393`	`397`	`vacrel->consider_bypass_optimization= true;`
`394`	`398`	`vacrel->do_index_vacuuming= true;`
`395`	`399`	`vacrel->do_index_cleanup= true;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4a6603c

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/vacuumlazy.c`

0 commit comments