NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4a3d806

committed

Use ExplainPropertyInteger for queryid in EXPLAIN

This saves a few lines of code. Also add a comment to mention why we useExplainPropertyInteger instead of ExplainPropertyUInteger given thatqueryid is a uint64 type.Author: David RowleyReviewed-by: Julien RouhaudDiscussion:https://postgr.es/m/CAApHDvqhSLYpSU_EqUdN39w9Uvb8ogmHV7_3YhJ0S3aScGBjsg@mail.gmail.comBackpatch-through: 14, where this code was originally added

1 parentc9229d3 commit4a3d806Copy full SHA for 4a3d806

File tree

1 file changed

-4

lines changed

src/backend/commands
- explain.c

1 file changed

-4

lines changed

`‎src/backend/commands/explain.c`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -606,10 +606,12 @@ ExplainOnePlan(PlannedStmt plannedstmt, IntoClause into, ExplainState *es,`
`606`	`606`
`607`	`607`	`if (es->verbose&&plannedstmt->queryId!=UINT64CONST(0))`
`608`	`608`	`{`
`609`		`-charbuf[MAXINT8LEN+1];`
`610`		`-`
`611`		`-pg_lltoa(plannedstmt->queryId,buf);`
`612`		`-ExplainPropertyText("Query Identifier",buf,es);`
	`609`	`+/*`
	`610`	`+ * Output the queryid as an int64 rather than a uint64 so we match`
	`611`	`+ * what would be seen in the BIGINT pg_stat_statements.queryid column.`
	`612`	`+ */`
	`613`	`+ExplainPropertyInteger("Query Identifier",NULL, (int64)`
	`614`	`+plannedstmt->queryId,es);`
`613`	`615`	`}`
`614`	`616`
`615`	`617`	`/* Show buffer usage in planning */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4a3d806

File tree

1 file changed

1 file changed

`‎src/backend/commands/explain.c`

0 commit comments