NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit49f49de

committed

Propagate parallel VACUUM's buffer access strategy.

Parallel VACUUM relied on global variable state from the leader processbeing propagated to workers on fork(). Commitb4af70c removed mostuses of global variables inside vacuumlazy.c, but did not account forthe buffer access strategy state.To fix, propagate the state through shared memory instead.Per buildfarm failures on elver, curculio, and morepork.Many thanks to Thomas Munro for off-list assistance with this issue.

1 parentb4af70c commit49f49deCopy full SHA for 49f49de

File tree

1 file changed

-0

lines changed

src/backend/access/heap
- vacuumlazy.c

1 file changed

-0

lines changed

`‎src/backend/access/heap/vacuumlazy.c`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,11 @@ typedef struct LVShared`
`194`	`194`	`Oidrelid;`
`195`	`195`	`intelevel;`
`196`	`196`
	`197`	`+/*`
	`198`	`+ * Buffer access strategy from leader`
	`199`	`+ */`
	`200`	`+BufferAccessStrategybstrategy;`
	`201`	`+`
`197`	`202`	`/*`
`198`	`203`	`* An indication for vacuum workers to perform either index vacuum or`
`199`	`204`	`* index cleanup. first_time is true only if for_cleanup is true and`
`@@ -3480,6 +3485,7 @@ begin_parallel_vacuum(LVRelState *vacrel, BlockNumber nblocks,`
`3480`	`3485`	`MemSet(shared,0,est_shared);`
`3481`	`3486`	`shared->relid=RelationGetRelid(vacrel->rel);`
`3482`	`3487`	`shared->elevel=elevel;`
	`3488`	`+shared->bstrategy=vacrel->bstrategy;`
`3483`	`3489`	`shared->maintenance_work_mem_worker=`
`3484`	`3490`	`(nindexes_mwm>0) ?`
`3485`	`3491`	`maintenance_work_mem /Min(parallel_workers,nindexes_mwm) :`
`@@ -3720,6 +3726,7 @@ parallel_vacuum_main(dsm_segment seg, shm_toc toc)`
`3720`	`3726`	`vacrel.rel=rel;`
`3721`	`3727`	`vacrel.indrels=indrels;`
`3722`	`3728`	`vacrel.nindexes=nindexes;`
	`3729`	`+vacrel.bstrategy=lvshared->bstrategy;`
`3723`	`3730`	`vacrel.indstats= (IndexBulkDeleteResult**)`
`3724`	`3731`	`palloc0(nindexessizeof(IndexBulkDeleteResult));`
`3725`	`3732`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit49f49de

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/vacuumlazy.c`

0 commit comments