forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit49c9d9f
committed
Unify VACUUM VERBOSE and autovacuum logging.
The log_autovacuum_min_duration instrumentation used its own dedicatedcode for logging, which was not reused by VACUUM VERBOSE. This washighly duplicative, and sometimes led to each code path using slightlydifferent accounting for essentially the same information.Clean things up by making VACUUM VERBOSE reuse the same instrumentationcode. This code restructuring changes the structure of the VACUUMVERBOSE output itself, but that seems like an overall improvement. Themost noticeable change in VACUUM VERBOSE output is that it no longeroutputs a distinct message per index per round of index vacuuming. Mostof the same information (about each index) is now shown in its newper-operation summary message. This is far more legible.A few details are no longer displayed by VACUUM VERBOSE, but that's noreal loss in practice, especially in the common case where we don't needmultiple index scans/rounds of vacuuming. This super fine-grainedinformation is still available via DEBUG2 messages, which might still beuseful in debugging scenarios.VACUUM VERBOSE now shows new instrumentation, which is typically veryuseful: all of the log_autovacuum_min_duration instrumentation that itmissed out on before now. This includes information about WAL overhead,buffers hit/missed/dirtied information, and I/O timing information.VACUUM VERBOSE still retains a few INFO messages of its own. This islimited to output concerning the progress of heap rel truncation, aswell as some basic information about parallel workers. These detailsare still potentially quite useful. They aren't a good fit for the logoutput, which must summarize the whole operation.Author: Peter Geoghegan <pg@bowt.ie>Reviewed-By: Masahiko Sawada <sawada.mshk@gmail.com>Reviewed-By: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/CAH2-WzmW4Me7_qR4X4ka7pxP-jGmn7=Npma_-Z-9Y1eD0MQRLw@mail.gmail.com1 parent0c53a66 commit49c9d9f
File tree
5 files changed
+93
-170
lines changed- doc/src/sgml
- src
- backend
- access/heap
- commands
- include/commands
5 files changed
+93
-170
lines changedLines changed: 6 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
7614 | 7614 |
| |
7615 | 7615 |
| |
7616 | 7616 |
| |
7617 |
| - | |
7618 |
| - | |
7619 |
| - | |
7620 |
| - | |
| 7617 | + | |
| 7618 | + | |
| 7619 | + | |
| 7620 | + | |
| 7621 | + | |
| 7622 | + | |
7621 | 7623 |
| |
7622 | 7624 |
| |
7623 | 7625 |
| |
|
0 commit comments
Comments
(0)