Movatterモバイル変換

Skip to content

postgrespro/postgresPublic

forked frompostgres/postgres

NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit49bff41

tglsfdc

committed

Remove some inappropriate #includes.

Other header files should never #include postgres.h (nor postgres_fe.h,nor c.h), per project policy. Also, there's no need for any backend .cfile to explicitly include elog.h or palloc.h, because postgres.h pullsthose in already.Extracted from a larger patch by Kyotaro Horiguchi. The rest of theremovals he suggests require more study, but these are no-brainers.Discussion:https://postgr.es/m/20180215.200447.209320006.horiguchi.kyotaro@lab.ntt.co.jp

1 parent2fb1aba commit49bff41Copy full SHA for 49bff41

File tree

7 files changed

+0

-7

lines changed

src
- backend
  - lib
    - knapsack.c
  - replication
    - basebackup.c
  - utils/misc
    - pg_config.c
    - rls.c
- include/lib
  - knapsack.h
- pl/plpython
  - plpy_spi.h
  - plpy_util.c

7 files changed

+0

-7

lines changed

`‎src/backend/lib/knapsack.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@`
`32`	`32`	`#include"nodes/bitmapset.h"`
`33`	`33`	`#include"utils/builtins.h"`
`34`	`34`	`#include"utils/memutils.h"`
`35`		`-#include"utils/palloc.h"`
`36`	`35`
`37`	`36`	`/*`
`38`	`37`	`* DiscreteKnapsack`

`‎src/backend/replication/basebackup.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@`
`34`	`34`	`#include"storage/fd.h"`
`35`	`35`	`#include"storage/ipc.h"`
`36`	`36`	`#include"utils/builtins.h"`
`37`		`-#include"utils/elog.h"`
`38`	`37`	`#include"utils/ps_status.h"`
`39`	`38`	`#include"utils/relcache.h"`
`40`	`39`	`#include"utils/timestamp.h"`

`‎src/backend/utils/misc/pg_config.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`	`#include"catalog/pg_type.h"`
`20`	`20`	`#include"common/config_info.h"`
`21`	`21`	`#include"utils/builtins.h"`
`22`		`-#include"utils/elog.h"`
`23`	`22`	`#include"port.h"`
`24`	`23`
`25`	`24`	`Datum`

`‎src/backend/utils/misc/rls.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@`
`22`	`22`	`#include"miscadmin.h"`
`23`	`23`	`#include"utils/acl.h"`
`24`	`24`	`#include"utils/builtins.h"`
`25`		`-#include"utils/elog.h"`
`26`	`25`	`#include"utils/lsyscache.h"`
`27`	`26`	`#include"utils/rls.h"`
`28`	`27`	`#include"utils/syscache.h"`

`‎src/include/lib/knapsack.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@`
`8`	`8`	`#ifndefKNAPSACK_H`
`9`	`9`	`#defineKNAPSACK_H`
`10`	`10`
`11`		`-#include"postgres.h"`
`12`	`11`	`#include"nodes/bitmapset.h"`
`13`	`12`
`14`	`13`	`externBitmapset*DiscreteKnapsack(intmax_weight,intnum_items,`

`‎src/pl/plpython/plpy_spi.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@`
`5`	`5`	`#ifndefPLPY_SPI_H`
`6`	`6`	`#definePLPY_SPI_H`
`7`	`7`
`8`		`-#include"utils/palloc.h"`
`9`	`8`	`#include"utils/resowner.h"`
`10`	`9`
`11`	`10`	`externPyObjectPLy_spi_prepare(PyObjectself,PyObject*args);`

`‎src/pl/plpython/plpy_util.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@`
`8`	`8`
`9`	`9`	`#include"mb/pg_wchar.h"`
`10`	`10`	`#include"utils/memutils.h"`
`11`		`-#include"utils/palloc.h"`
`12`	`11`
`13`	`12`	`#include"plpython.h"`
`14`	`13`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp