Commit49967da

committed

Make vacuum a bit more verbose to debug BF failure.

This is temporary. While possibly some more error checking / debuggingin this path would be a good thing, it'll not look exactly like this.Discussion:https://postgr.es/m/20200816181604.l54m6kss5ntd6xow@alap3.anarazel.de

1 parent676a9c3 commit49967daCopy full SHA for 49967da

File tree

+17

-1

lines changed

+17

-1

lines changed

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6048,7 +6048,16 @@ FreezeMultiXactId(MultiXactId multi, uint16 t_infomask,`
`6048`	`6048`	`TransactionIdIsInProgress(members[i].xid))`
`6049`	`6049`	`{`
`6050`	`6050`	`/* running locker cannot possibly be older than the cutoff */`
`6051`		`-Assert(!TransactionIdPrecedes(members[i].xid,cutoff_xid));`
	`6051`	`+if (TransactionIdPrecedes(members[i].xid,cutoff_xid))`
	`6052`	`+{`
	`6053`	`+/* temporary on-bf debugging */`
	`6054`	`+elog(PANIC,"too old alive locker: multi: %u, member xid: %u, memb-current: %d, memb-progress: %d, cutoff: %u, cutoff-multi: %u, relfrozenxid: %u, relminmxid: %u",`
	`6055`	`+multi,members[i].xid,`
	`6056`	`+TransactionIdIsCurrentTransactionId(members[i].xid),`
	`6057`	`+TransactionIdIsInProgress(members[i].xid),`
	`6058`	`+cutoff_xid,cutoff_multi,`
	`6059`	`+relfrozenxid,relminmxid);`
	`6060`	`+}`
`6052`	`6061`	`newmembers[nnewmembers++]=members[i];`
`6053`	`6062`	`has_lockers= true;`
`6054`	`6063`	`}`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1350,7 +1350,14 @@ lazy_scan_heap(Relation onerel, VacuumParams params, LVRelStats vacrelstats,`
`1350`	`1350`	`if (HeapTupleIsHotUpdated(&tuple)\|\|`
`1351`	`1351`	`HeapTupleIsHeapOnly(&tuple)\|\|`
`1352`	`1352`	`params->index_cleanup==VACOPT_TERNARY_DISABLED)`
	`1353`	`+{`
	`1354`	`+/* temporary on-bf debugging */`
	`1355`	`+elog(LOG,"treating dead HOT tuple (updated %d, heap only: %d, index cleanup: %d) as alive",`
	`1356`	`+HeapTupleIsHotUpdated(&tuple),HeapTupleIsHeapOnly(&tuple),`
	`1357`	`+params->index_cleanup==VACOPT_TERNARY_DISABLED);`
	`1358`	`+`
`1353`	`1359`	`nkeep+=1;`
	`1360`	`+}`
`1354`	`1361`	`else`
`1355`	`1362`	`tupgone= true;/* we can delete the tuple */`
`1356`	`1363`	`all_visible= false;`

Comments

(0)