NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4951a88

committed

copyObject() and equal() now know about all parse-time node types,

including utility statements. Still can't copy or compare executorstate, but at present that doesn't seem to be necessary. This makesit possible to execute most (all?) utility statements in plpgsql.Had to change parsetree representation of CreateTrigStmt so that itcontained only legal Nodes, and not bare string constants.

1 parent66fd8f8 commit4951a88Copy full SHA for 4951a88

File tree

6 files changed

+2421

-184

lines changed

src/backend
- commands
  - trigger.c
- nodes
  - copyfuncs.c
  - equalfuncs.c
- parser
  - analyze.c
  - gram.y
- tcop
  - postgres.c

6 files changed

+2421

-184

lines changed

`‎src/backend/commands/trigger.c`

Lines changed: 5 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/commands/trigger.c,v 1.75 2000/08/03 19:19:18 tgl Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/trigger.c,v 1.76 2000/08/11 23:45:28 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -212,7 +212,7 @@ CreateTrigger(CreateTrigStmt *stmt)`
`212`	`212`
`213`	`213`	`foreach(le,stmt->args)`
`214`	`214`	`{`
`215`		`-charar= (char)lfirst(le);`
	`215`	`+charar= ((Value)lfirst(le))->val.str;`
`216`	`216`
`217`	`217`	`len+=strlen(ar)+4;`
`218`	`218`	`for (;*ar;ar++)`
`@@ -222,10 +222,10 @@ CreateTrigger(CreateTrigStmt *stmt)`
`222`	`222`	`}`
`223`	`223`	`}`
`224`	`224`	`args= (char*)palloc(len+1);`
`225`		`-args[0]=0;`
	`225`	`+args[0]='\0';`
`226`	`226`	`foreach(le,stmt->args)`
`227`	`227`	`{`
`228`		`-chars= (char)lfirst(le);`
	`228`	`+chars= ((Value)lfirst(le))->val.str;`
`229`	`229`	`char*d=args+strlen(args);`
`230`	`230`
`231`	`231`	`while (*s)`
`@@ -234,8 +234,7 @@ CreateTrigger(CreateTrigStmt *stmt)`
`234`	`234`	`*d++='\\';`
`235`	`235`	`d++=s++;`
`236`	`236`	`}`
`237`		`-*d=0;`
`238`		`-strcat(args,"\\000");`
	`237`	`+strcpy(d,"\\000");`
`239`	`238`	`}`
`240`	`239`	`values[Anum_pg_trigger_tgnargs-1]=Int16GetDatum(nargs);`
`241`	`240`	`values[Anum_pg_trigger_tgargs-1]=DirectFunctionCall1(byteain,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4951a88

File tree

6 files changed

6 files changed

`‎src/backend/commands/trigger.c`

0 commit comments