NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4950f09

committed

Fix thinko when ending progress report for a backend

The logic ending progress reporting for a backend entry introduced byb6fb647 causes callers of pgstat_progress_end_command() to do some extrawork when track_activities is enabled as the process fields are reset inthe backend entry even if no command were started for reporting.This resets the fields only if a command is registered for progressreporting, and only if track_activities is enabled.Author: Masahiho SawadaDiscussion:https://postgr.es/m/CAD21AoCry_vJ0E-m5oxJXGL3pnos-xYGCzF95rK5Bbi3Uf-rpA@mail.gmail.comBackpatch-through: 9.6

1 parentdbbae33 commit4950f09Copy full SHA for 4950f09

File tree

1 file changed

-3

lines changed

src/backend/postmaster
- pgstat.c

1 file changed

-3

lines changed

`‎src/backend/postmaster/pgstat.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3181,10 +3181,10 @@ pgstat_progress_end_command(void)`
`3181`	`3181`	`{`
`3182`	`3182`	`volatilePgBackendStatus*beentry=MyBEEntry;`
`3183`	`3183`
`3184`		`-if (!beentry)`
	`3184`	`+if (!beentry\|\| !pgstat_track_activities)`
`3185`	`3185`	`return;`
`3186`		`-if (!pgstat_track_activities`
`3187`		`-&&beentry->st_progress_command==PROGRESS_COMMAND_INVALID)`
	`3186`	`+`
	`3187`	`+if (beentry->st_progress_command==PROGRESS_COMMAND_INVALID)`
`3188`	`3188`	`return;`
`3189`	`3189`
`3190`	`3190`	`PGSTAT_BEGIN_WRITE_ACTIVITY(beentry);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4950f09

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/pgstat.c`

0 commit comments