NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit494f3cb

committed

Fix incorrect close() call in dsm_impl_mmap().

One improbable error-exit path in this function used close() whereit should have used CloseTransientFile(). This is unlikely to behit in the field, and I think the consequences wouldn't be awful(just an elog(LOG) bleat later). But a bug is a bug, so back-patchto 9.4 where this code came in.Pan BianDiscussion:https://postgr.es/m/152056616579.4966.583293218357089052@wrigleys.postgresql.org

1 parent5b0fa06 commit494f3cbCopy full SHA for 494f3cb

File tree

1 file changed

-1

lines changed

src/backend/storage/ipc
- dsm_impl.c

1 file changed

-1

lines changed

`‎src/backend/storage/ipc/dsm_impl.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -923,7 +923,7 @@ dsm_impl_mmap(dsm_op op, dsm_handle handle, Size request_size,`
`923`	`923`
`924`	`924`	`/* Back out what's already been done. */`
`925`	`925`	`save_errno=errno;`
`926`		`-close(fd);`
	`926`	`+CloseTransientFile(fd);`
`927`	`927`	`if (op==DSM_OP_CREATE)`
`928`	`928`	`unlink(name);`
`929`	`929`	`errno=save_errno;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit494f3cb

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/dsm_impl.c`

0 commit comments