NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit48d4a8c

Amit Kapila

committed

Allocate access strategy in parallel VACUUM workers.

Currently, parallel vacuum workers don't use any buffer access strategy.We can fix it either by propagating the access strategy from a leader orallow each worker to use BAS_VACUUM access strategy type. We don't seemuch use in propagating this information from leader as both leader andworkers are supposed to use the same strategy. We might want to use adifferent access strategy for leader and workers but that would be aseparate optimization not suitable for back-branches. This has been fixedin HEAD as commitf6b8f19.Author: Amit KapilaReviewed-by: Sawada Masahiko, Bharath RupireddyDiscussion:https://postgr.es/m/CAA4eK1KbmJgRV2W3BbzRnKUSrukN7SbqBBriC4RDB5KBhopkGQ@mail.gmail.com

1 parentbe79deb commit48d4a8cCopy full SHA for 48d4a8c

File tree

1 file changed

-0

lines changed

src/backend/access/heap
- vacuumlazy.c

1 file changed

-0

lines changed

`‎src/backend/access/heap/vacuumlazy.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3510,6 +3510,9 @@ parallel_vacuum_main(dsm_segment seg, shm_toc toc)`
`3510`	`3510`	`vac_open_indexes(onerel,RowExclusiveLock,&nindexes,&indrels);`
`3511`	`3511`	`Assert(nindexes>0);`
`3512`	`3512`
	`3513`	`+/* Each parallel VACUUM worker gets its own access strategy */`
	`3514`	`+vac_strategy=GetAccessStrategy(BAS_VACUUM);`
	`3515`	`+`
`3513`	`3516`	`/* Set dead tuple space */`
`3514`	`3517`	`dead_tuples= (LVDeadTuples*)shm_toc_lookup(toc,`
`3515`	`3518`	`PARALLEL_VACUUM_KEY_DEAD_TUPLES,`
`@@ -3564,6 +3567,7 @@ parallel_vacuum_main(dsm_segment seg, shm_toc toc)`
`3564`	`3567`
`3565`	`3568`	`vac_close_indexes(nindexes,indrels,RowExclusiveLock);`
`3566`	`3569`	`table_close(onerel,ShareUpdateExclusiveLock);`
	`3570`	`+FreeAccessStrategy(vac_strategy);`
`3567`	`3571`	`pfree(stats);`
`3568`	`3572`	`}`
`3569`	`3573`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit48d4a8c

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/vacuumlazy.c`

0 commit comments