Commit48cc59e

committed

Use standard compare_exchange loop style in ProcArrayGroupClearXid().

Besides style, this might improve performance in the contended case.Reviewed by Amit Kapila.Discussion:https://postgr.es/m/20191015035348.GA4166224@rfd.leadboat.com

1 parent30ee5d1 commit48cc59eCopy full SHA for 48cc59e

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -493,9 +493,9 @@ ProcArrayGroupClearXid(PGPROC *proc, TransactionId latestXid)`
`493`	`493`	`/* Add ourselves to the list of processes needing a group XID clear. */`
`494`	`494`	`proc->procArrayGroupMember= true;`
`495`	`495`	`proc->procArrayGroupMemberXid=latestXid;`
	`496`	`+nextidx=pg_atomic_read_u32(&procglobal->procArrayGroupFirst);`
`496`	`497`	`while (true)`
`497`	`498`	`{`
`498`		`-nextidx=pg_atomic_read_u32(&procglobal->procArrayGroupFirst);`
`499`	`499`	`pg_atomic_write_u32(&proc->procArrayGroupNext,nextidx);`
`500`	`500`
`501`	`501`	`if (pg_atomic_compare_exchange_u32(&procglobal->procArrayGroupFirst,`

Comments

(0)