NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit48c9f49

committed

Fix race condition when changing synchronous_standby_names

A momentary window exists when synchronous_standby_nameschanges that allows commands issued after the change tocontinue to act as async until the change becomes visible.Remove the race by using more appropriate test in syncrep.cAuthor: Asim Rama Praveen and Ashwin AgrawalReported-by: Xin Zhang, Ashwin Agrawal, and Asim Rama PraveenReviewed-by: Michael Paquier, Masahiko Sawada

1 parent2958a67 commit48c9f49Copy full SHA for 48c9f49

File tree

1 file changed

-4

lines changed

src/backend/replication
- syncrep.c

1 file changed

-4

lines changed

`‎src/backend/replication/syncrep.c`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -156,11 +156,9 @@ SyncRepWaitForLSN(XLogRecPtr lsn, bool commit)`
`156`	`156`	`mode=Min(SyncRepWaitMode,SYNC_REP_WAIT_FLUSH);`
`157`	`157`
`158`	`158`	`/*`
`159`		`- * Fast exit if user has not requested sync replication, or there are no`
`160`		`- * sync replication standby names defined. Note that those standbys don't`
`161`		`- * need to be connected.`
	`159`	`+ * Fast exit if user has not requested sync replication.`
`162`	`160`	`*/`
`163`		`-if (!SyncRepRequested()\|\| !SyncStandbysDefined())`
	`161`	`+if (!SyncRepRequested())`
`164`	`162`	`return;`
`165`	`163`
`166`	`164`	`Assert(SHMQueueIsDetached(&(MyProc->syncRepLinks)));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit48c9f49

File tree

1 file changed

1 file changed

`‎src/backend/replication/syncrep.c`

0 commit comments