Commit48412f1

tglsfdc

authored and

pull[bot]

committed

Don't leave roles behind after core regression tests.

Commitscf5eb37 ande5b8a4c each created a new role that theyforgot to remove again. This breaks the use-case of running "makeinstallcheck" more than once, and it's also against project policybecause it'd be quite unfriendly behavior if one were running"make installcheck" against a non-throwaway installation.

1 parent86c0d29 commit48412f1Copy full SHA for 48412f1

File tree

2 files changed

+11

-2

lines changed

src/test/regress
- expected
  - create_role.out
- sql
  - create_role.sql

2 files changed

+11

-2

lines changed

`‎src/test/regress/expected/create_role.out`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -174,18 +174,23 @@ DROP ROLE regress_password_null;`
`174`	`174`	`DROP ROLE regress_noiseword;`
`175`	`175`	`DROP ROLE regress_inroles;`
`176`	`176`	`DROP ROLE regress_adminroles;`
`177`		`--- fail, cannot drop ourself nor superusers`
	`177`	`+-- fail, cannot drop ourself, nor superusers or roles we lack ADMIN for`
`178`	`178`	`DROP ROLE regress_role_super;`
`179`	`179`	`ERROR: must be superuser to drop superusers`
`180`	`180`	`DROP ROLE regress_role_admin;`
`181`	`181`	`ERROR: current user cannot be dropped`
	`182`	`+DROP ROLE regress_rolecreator;`
	`183`	`+ERROR: must have admin option on role "regress_rolecreator"`
`182`	`184`	`-- ok`
`183`	`185`	`RESET SESSION AUTHORIZATION;`
`184`	`186`	`REVOKE CREATE ON DATABASE regression FROM regress_role_admin CASCADE;`
`185`	`187`	`DROP INDEX tenant_idx;`
`186`	`188`	`DROP TABLE tenant_table;`
`187`	`189`	`DROP VIEW tenant_view;`
	`190`	`+DROP SCHEMA regress_tenant2_schema;`
`188`	`191`	`DROP ROLE regress_tenant;`
	`192`	`+DROP ROLE regress_tenant2;`
	`193`	`+DROP ROLE regress_rolecreator;`
`189`	`194`	`DROP ROLE regress_role_admin;`
`190`	`195`	`DROP ROLE regress_role_super;`
`191`	`196`	`DROP ROLE regress_role_normal;`

`‎src/test/regress/sql/create_role.sql`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -161,17 +161,21 @@ DROP ROLE regress_noiseword;`
`161`	`161`	`DROP ROLE regress_inroles;`
`162`	`162`	`DROP ROLE regress_adminroles;`
`163`	`163`
`164`		`--- fail, cannot drop ourself nor superusers`
	`164`	`+-- fail, cannot drop ourself, nor superusers or roles we lack ADMIN for`
`165`	`165`	`DROP ROLE regress_role_super;`
`166`	`166`	`DROP ROLE regress_role_admin;`
	`167`	`+DROP ROLE regress_rolecreator;`
`167`	`168`
`168`	`169`	`-- ok`
`169`	`170`	`RESET SESSION AUTHORIZATION;`
`170`	`171`	`REVOKE CREATEON DATABASE regressionFROM regress_role_admin CASCADE;`
`171`	`172`	`DROPINDEX tenant_idx;`
`172`	`173`	`DROPTABLE tenant_table;`
`173`	`174`	`DROPVIEW tenant_view;`
	`175`	`+DROPSCHEMA regress_tenant2_schema;`
`174`	`176`	`DROP ROLE regress_tenant;`
	`177`	`+DROP ROLE regress_tenant2;`
	`178`	`+DROP ROLE regress_rolecreator;`
`175`	`179`	`DROP ROLE regress_role_admin;`
`176`	`180`	`DROP ROLE regress_role_super;`
`177`	`181`	`DROP ROLE regress_role_normal;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit48412f1

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/create_role.out`

`‎src/test/regress/sql/create_role.sql`

0 commit comments