Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit47fd420

Browse files
committed
Have walsenders participate in procsignal infrastructure.
The non-participation in procsignal was a problem for both changes inmaster, e.g. parallelism not working for normal statements run inwalsender backends, and older branches, e.g. recovery conflicts andcatchup interrupts not working for logical decoding walsenders.This commit thus replaces the previous WalSndXLogSendHandler withprocsignal_sigusr1_handler. In branches sincedb0f6ca that canlead to additional SetLatch calls, but that only rarely seems to makea difference.Author: Andres FreundReviewed-By: Michael PaquierDiscussion:https://postgr.es/m/20170421014030.fdzvvvbrz4nckrow@alap3.anarazel.deBackpatch: 9.4, earlier commits don't seem to benefit sufficiently
1 parent703f148 commit47fd420

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

‎src/backend/replication/walsender.c

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ static struct
212212

213213
/* Signal handlers */
214214
staticvoidWalSndSigHupHandler(SIGNAL_ARGS);
215-
staticvoidWalSndXLogSendHandler(SIGNAL_ARGS);
216215
staticvoidWalSndLastCycleHandler(SIGNAL_ARGS);
217216

218217
/* Prototypes for private functions */
@@ -2857,17 +2856,6 @@ WalSndSigHupHandler(SIGNAL_ARGS)
28572856
errno=save_errno;
28582857
}
28592858

2860-
/* SIGUSR1: set flag to send WAL records */
2861-
staticvoid
2862-
WalSndXLogSendHandler(SIGNAL_ARGS)
2863-
{
2864-
intsave_errno=errno;
2865-
2866-
latch_sigusr1_handler();
2867-
2868-
errno=save_errno;
2869-
}
2870-
28712859
/* SIGUSR2: set flag to do a last cycle and shut down afterwards */
28722860
staticvoid
28732861
WalSndLastCycleHandler(SIGNAL_ARGS)
@@ -2901,7 +2889,7 @@ WalSndSignals(void)
29012889
pqsignal(SIGQUIT,quickdie);/* hard crash time */
29022890
InitializeTimeouts();/* establishes SIGALRM handler */
29032891
pqsignal(SIGPIPE,SIG_IGN);
2904-
pqsignal(SIGUSR1,WalSndXLogSendHandler);/* request WAL sending */
2892+
pqsignal(SIGUSR1,procsignal_sigusr1_handler);
29052893
pqsignal(SIGUSR2,WalSndLastCycleHandler);/* request a last cycle and
29062894
* shutdown */
29072895

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp