NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit47c93ac

committed

Fix portability failure introduced in commitsd2b0b60 et al.

I made a frontend fprintf() format use %m, forgetting that that's onlysafe in HEAD not the back branches; prior to96bf88d andd6c55de,it would work on glibc platforms but not elsewhere. Revert to using%s ... strerror(errno) as the code did before.We could have left HEAD as-is, but for code consistency across branches,I chose to apply this patch there too.Per Coverity and a few buildfarm members.

1 parenta016f59 commit47c93acCopy full SHA for 47c93ac

File tree

1 file changed

-1

lines changed

src/common
- psprintf.c

1 file changed

-1

lines changed

`‎src/common/psprintf.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,8 @@ pvsnprintf(char buf, size_t len, const char fmt, va_list args)`
`131`	`131`	`#ifndefFRONTEND`
`132`	`132`	`elog(ERROR,"vsnprintf failed: %m with format string \"%s\"",fmt);`
`133`	`133`	`#else`
`134`		`-fprintf(stderr,"vsnprintf failed: %m with format string \"%s\"\n",fmt);`
	`134`	`+fprintf(stderr,"vsnprintf failed: %s with format string \"%s\"\n",`
	`135`	`+strerror(errno),fmt);`
`135`	`136`	`exit(EXIT_FAILURE);`
`136`	`137`	`#endif`
`137`	`138`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit47c93ac

File tree

1 file changed

1 file changed

`‎src/common/psprintf.c`

0 commit comments