forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit4766438
committed
Adjust some comments about structure properties in pg_stat.h
One comment of PgStat_TableCounts mentioned that its pending stats usememcmp() to check for the all-zero case if there is any activity. Thisis not true since07e9e28, as pg_memory_is_all_zeros() is used.PgStat_FunctionCounts incorrectly documented that it relied on memcpy().This has never been correct, and not relevant because functionstatistics do not have an all-zero check for pending stats.Checkpoint and bgwriter statistics have been always relying on memcmp()or pg_memory_is_all_zeros() (since07e9e28 for the latter), and nevermentioned the dependency on event counters for their all-zero checks.Let's document these properties, like the table statistics.Author: Bertrand DrouvotDiscussion:https://postgr.es/m/Z1hNLvcPgVLPxCoc@ip-10-97-1-34.eu-west-3.compute.internal1 parentbd10ec5 commit4766438
1 file changed
+20
-5
lines changedLines changed: 20 additions & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
128 | 128 |
| |
129 | 129 |
| |
130 | 130 |
| |
131 |
| - | |
132 |
| - | |
133 |
| - | |
134 | 131 |
| |
135 | 132 |
| |
136 | 133 |
| |
| |||
172 | 169 |
| |
173 | 170 |
| |
174 | 171 |
| |
175 |
| - | |
176 |
| - | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
177 | 176 |
| |
178 | 177 |
| |
179 | 178 |
| |
| |||
282 | 281 |
| |
283 | 282 |
| |
284 | 283 |
| |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
285 | 292 |
| |
286 | 293 |
| |
287 | 294 |
| |
| |||
290 | 297 |
| |
291 | 298 |
| |
292 | 299 |
| |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
293 | 308 |
| |
294 | 309 |
| |
295 | 310 |
| |
|
0 commit comments
Comments
(0)