NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4723b2b

committed

Be more careful about the difference between signed and unsigned ints.

Bug is revealed by OID regress test on 64-bit platforms.

1 parenteedfac6 commit4723b2bCopy full SHA for 4723b2b

File tree

1 file changed

+13

-14

lines changed

src/backend/port
- snprintf.c

1 file changed

+13

-14

lines changed

`‎src/backend/port/snprintf.c‎`

Lines changed: 13 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ typedef unsigned long ulong_long;`
`74`	`74`	`* causing nast effects.`
`75`	`75`	`**************************************************************/`
`76`	`76`
`77`		`-/static char _id[] = "$Id: snprintf.c,v 1.28 2000/12/03 20:45:34 tgl Exp $";/`
	`77`	`+/static char _id[] = "$Id: snprintf.c,v 1.29 2000/12/30 19:17:47 tgl Exp $";/`
`78`	`78`	`staticchar*end;`
`79`	`79`	`staticintSnprfOverflow;`
`80`	`80`
`@@ -192,12 +192,12 @@ dopr(char buffer, const char format, va_list args)`
`192`	`192`	`if (longflag)`
`193`	`193`	`{`
`194`	`194`	`if (longlongflag)`
`195`		`-value=va_arg(args,long_long);`
	`195`	`+value=va_arg(args,ulong_long);`
`196`	`196`	`else`
`197`		`-value=va_arg(args,long);`
	`197`	`+value=va_arg(args,unsignedlong);`
`198`	`198`	`}`
`199`	`199`	`else`
`200`		`-value=va_arg(args,int);`
	`200`	`+value=va_arg(args,unsignedint);`
`201`	`201`	`fmtnum(value,10,0,ljust,len,zpad);`
`202`	`202`	`break;`
`203`	`203`	`case'o':`
`@@ -206,12 +206,12 @@ dopr(char buffer, const char format, va_list args)`
`206`	`206`	`if (longflag)`
`207`	`207`	`{`
`208`	`208`	`if (longlongflag)`
`209`		`-value=va_arg(args,long_long);`
	`209`	`+value=va_arg(args,ulong_long);`
`210`	`210`	`else`
`211`		`-value=va_arg(args,long);`
	`211`	`+value=va_arg(args,unsignedlong);`
`212`	`212`	`}`
`213`	`213`	`else`
`214`		`-value=va_arg(args,int);`
	`214`	`+value=va_arg(args,unsignedint);`
`215`	`215`	`fmtnum(value,8,0,ljust,len,zpad);`
`216`	`216`	`break;`
`217`	`217`	`case'd':`
`@@ -225,31 +225,30 @@ dopr(char buffer, const char format, va_list args)`
`225`	`225`	`}`
`226`	`226`	`else`
`227`	`227`	`value=va_arg(args,int);`
`228`		`-`
`229`	`228`	`fmtnum(value,10,1,ljust,len,zpad);`
`230`	`229`	`break;`
`231`	`230`	`case'x':`
`232`	`231`	`if (longflag)`
`233`	`232`	`{`
`234`	`233`	`if (longlongflag)`
`235`		`-value=va_arg(args,long_long);`
	`234`	`+value=va_arg(args,ulong_long);`
`236`	`235`	`else`
`237`		`-value=va_arg(args,long);`
	`236`	`+value=va_arg(args,unsignedlong);`
`238`	`237`	`}`
`239`	`238`	`else`
`240`		`-value=va_arg(args,int);`
	`239`	`+value=va_arg(args,unsignedint);`
`241`	`240`	`fmtnum(value,16,0,ljust,len,zpad);`
`242`	`241`	`break;`
`243`	`242`	`case'X':`
`244`	`243`	`if (longflag)`
`245`	`244`	`{`
`246`	`245`	`if (longlongflag)`
`247`		`-value=va_arg(args,long_long);`
	`246`	`+value=va_arg(args,ulong_long);`
`248`	`247`	`else`
`249`		`-value=va_arg(args,long);`
	`248`	`+value=va_arg(args,unsignedlong);`
`250`	`249`	`}`
`251`	`250`	`else`
`252`		`-value=va_arg(args,int);`
	`251`	`+value=va_arg(args,unsignedint);`
`253`	`252`	`fmtnum(value,-16,0,ljust,len,zpad);`
`254`	`253`	`break;`
`255`	`254`	`case's':`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4723b2b

File tree

1 file changed

1 file changed

`‎src/backend/port/snprintf.c‎`

0 commit comments