NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit471a7af

committed

Ensure consistent sort order of large objects in pg_dump.

The primary purpose of this commit is to ensure pg_upgrade tests yieldcomparable dumps pre/post upgrade, which got broken by12a53c7 /578b229, as the order in pg_largeobject_metadata is likely todiffer pre/post upgrade.It also seems like a generally good idea to make sure such dumps arecomparable, outside of pg_upgrade tests.LO metadata already was already dumped in an ordered manner as themetadata is dumped in a well defined order viasortDumpableObjectsByTypeName() and sortDumpableObjects(). But largeobject data is currently not tracked via that mechanism.As Tom points out it seems possible that at some point dumpBlobs() wasassumed to dump out objects in a well defined order, due to the use ofDISTINCT, which at that time only was done using sorting.Per complaint from Andrew Dunstan and discussion with him and TomLane.Author: Andres FreundDiscussion:https://postgr.es/m/2735.1543333649@sss.pgh.pa.us

1 parentb238527 commit471a7afCopy full SHA for 471a7af

File tree

1 file changed

-2

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-2

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3328,9 +3328,13 @@ dumpBlobs(Archive fout, void arg)`
`3328`	`3328`	`* the already-in-memory dumpable objects instead...`
`3329`	`3329`	`*/`
`3330`	`3330`	`if (fout->remoteVersion >= 90000)`
`3331`		`-blobQry = "DECLARE bloboid CURSOR FOR SELECT oid FROM pg_largeobject_metadata";`
	`3331`	`+blobQry =`
	`3332`	`+"DECLARE bloboid CURSOR FOR "`
	`3333`	`+"SELECT oid FROM pg_largeobject_metadata ORDER BY 1";`
`3332`	`3334`	`else`
`3333`		`-blobQry = "DECLARE bloboid CURSOR FOR SELECT DISTINCT loid FROM pg_largeobject";`
	`3335`	`+blobQry =`
	`3336`	`+"DECLARE bloboid CURSOR FOR "`
	`3337`	`+"SELECT DISTINCT loid FROM pg_largeobject ORDER BY 1";`
`3334`	`3338`
`3335`	`3339`	`ExecuteSqlStatement(fout, blobQry);`
`3336`	`3340`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit471a7af

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments