NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit46c1932

committed

Fix possible lockup in pgbench with -R.

pgbench would sometimes get stuck waiting forever after its lastclient thread terminated, due to failing to check for there beingnothing more to wait for.Bug introduced during refactoring in v10 (I didn't bother to try toassign blame to a specific commit). It's already repaired inHEAD/v12 thanks to commit3bac77c, but v10 and v11 need this fix.Fabien Coelho, per report from Tomas Vondra; reviewed byYoshikazu ImaiDiscussion:https://postgr.es/m/cc5d76c1-6144-bbed-ad1b-961d13d88f3b@2ndquadrant.com

1 parent55862b2 commit46c1932Copy full SHA for 46c1932

File tree

1 file changed

-0

lines changed

src/bin/pgbench
- pgbench.c

1 file changed

-0

lines changed

`‎src/bin/pgbench/pgbench.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4515,6 +4515,10 @@ threadRun(void *arg)`
`4515`	`4515`	`}`
`4516`	`4516`	`}`
`4517`	`4517`
	`4518`	`+/* under throttling we may have finished the last client above */`
	`4519`	`+if (remains==0)`
	`4520`	`+break;`
	`4521`	`+`
`4518`	`4522`	`/* also wake up to print the next progress report on time */`
`4519`	`4523`	`if (progress&&min_usec>0&&thread->tid==0)`
`4520`	`4524`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit46c1932

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/pgbench.c`

0 commit comments