forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit46b5e7c
committed
Revert "Distinguish printf-like functions that support %m from those that don't."
This reverts commit3a60c8f. Buildfarmresults show that that caused a whole bunch of new warnings on platformswhere gcc believes the local printf to be non-POSIX-compliant. Thisproblem outweighs the hypothetical-anyway possibility of getting warningsfor misuse of %m. We could use gnu_printf archetype when we've substitutedsrc/port/snprintf.c, but that brings us right back to the problem of notgetting warnings for %m.A possible answer is to attack it in the other direction by insistingthat %m support be included in printf's feature set, but that will takemore investigation. In the meantime, revert the previous change, andupdate the comment for PGAC_C_PRINTF_ARCHETYPE to more fully explainwhat's going on.Discussion:https://postgr.es/m/2975.1526862605@sss.pgh.pa.us1 parentd11eae0 commit46b5e7c
File tree
5 files changed
+34
-32
lines changed- config
- src/include
- utils
5 files changed
+34
-32
lines changedLines changed: 13 additions & 7 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
19 | 19 |
| |
20 | 20 |
| |
21 | 21 |
| |
22 |
| - | |
23 |
| - | |
24 |
| - | |
25 |
| - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
26 | 32 |
| |
27 |
| - | |
| 33 | + | |
28 | 34 |
| |
29 | 35 |
| |
30 | 36 |
| |
| |||
34 | 40 |
| |
35 | 41 |
| |
36 | 42 |
| |
37 |
| - | |
38 |
| - | |
| 43 | + | |
| 44 | + | |
39 | 45 |
| |
40 | 46 |
| |
41 | 47 |
| |
|
Lines changed: 3 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
13362 | 13362 |
| |
13363 | 13363 |
| |
13364 | 13364 |
| |
13365 |
| - | |
13366 |
| - | |
| 13365 | + | |
| 13366 | + | |
13367 | 13367 |
| |
13368 | 13368 |
| |
13369 | 13369 |
| |
| |||
13394 | 13394 |
| |
13395 | 13395 |
| |
13396 | 13396 |
| |
13397 |
| - | |
| 13397 | + | |
13398 | 13398 |
| |
13399 | 13399 |
| |
13400 | 13400 |
| |
|
Lines changed: 1 addition & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
126 | 126 |
| |
127 | 127 |
| |
128 | 128 |
| |
129 |
| - | |
130 |
| - | |
131 |
| - | |
132 |
| - | |
| 129 | + | |
133 | 130 |
| |
134 | 131 |
| |
135 | 132 |
| |
136 |
| - | |
137 | 133 |
| |
138 | 134 |
| |
139 | 135 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
809 | 809 |
| |
810 | 810 |
| |
811 | 811 |
| |
812 |
| - | |
813 |
| - | |
| 812 | + | |
| 813 | + | |
814 | 814 |
| |
815 | 815 |
| |
816 | 816 |
| |
|
Lines changed: 15 additions & 15 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
152 | 152 |
| |
153 | 153 |
| |
154 | 154 |
| |
155 |
| - | |
156 |
| - | |
| 155 | + | |
| 156 | + | |
157 | 157 |
| |
158 | 158 |
| |
159 |
| - | |
| 159 | + | |
160 | 160 |
| |
161 |
| - | |
162 |
| - | |
| 161 | + | |
| 162 | + | |
163 | 163 |
| |
164 |
| - | |
| 164 | + | |
165 | 165 |
| |
166 | 166 |
| |
167 | 167 |
| |
168 |
| - | |
| 168 | + | |
169 | 169 |
| |
170 | 170 |
| |
171 |
| - | |
| 171 | + | |
172 | 172 |
| |
173 |
| - | |
| 173 | + | |
174 | 174 |
| |
175 | 175 |
| |
176 | 176 |
| |
| |||
184 | 184 |
| |
185 | 185 |
| |
186 | 186 |
| |
187 |
| - | |
| 187 | + | |
188 | 188 |
| |
189 | 189 |
| |
190 | 190 |
| |
| |||
243 | 243 |
| |
244 | 244 |
| |
245 | 245 |
| |
246 |
| - | |
| 246 | + | |
247 | 247 |
| |
248 | 248 |
| |
249 | 249 |
| |
250 | 250 |
| |
251 | 251 |
| |
252 |
| - | |
| 252 | + | |
253 | 253 |
| |
254 | 254 |
| |
255 | 255 |
| |
| |||
428 | 428 |
| |
429 | 429 |
| |
430 | 430 |
| |
431 |
| - | |
432 |
| - | |
433 |
| - | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
434 | 434 |
| |
435 | 435 |
| |
436 | 436 |
| |
|
0 commit comments
Comments
(0)