NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit46acbeb

committed

Make HEAP_LOCK/HEAP2_LOCK_UPDATED replay reset HEAP_XMAX_INVALID.

0ac5ad5 started to compress infomask bits in WAL records. Unfortunatelythe replay routines for XLOG_HEAP_LOCK/XLOG_HEAP2_LOCK_UPDATED forgot toreset the HEAP_XMAX_INVALID (and some other) hint bits.Luckily that's not problematic in the majority of cases, because after acrash/on a standby row locks aren't meaningful. Unfortunately that doesnot hold true in the presence of prepared transactions. This means thatafter a crash, or after promotion, row level locks held by a prepared,but not yet committed, prepared transaction might not be enforced.Discussion: 20160715192319.ubfuzim4zv3rqnxv@alap3.anarazel.deBackpatch: 9.3, the oldest branch on which0ac5ad5 is present.

1 parent6c243f9 commit46acbebCopy full SHA for 46acbeb

File tree

1 file changed

-0

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-0

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -7865,6 +7865,8 @@ heap_xlog_lock(XLogRecPtr lsn, XLogRecord *record)`
`7865`	`7865`
`7866`	`7866`	`htup= (HeapTupleHeader)PageGetItem(page,lp);`
`7867`	`7867`
	`7868`	`+htup->t_infomask &= ~(HEAP_XMAX_BITS \|HEAP_MOVED);`
	`7869`	`+htup->t_infomask2 &= ~HEAP_KEYS_UPDATED;`
`7868`	`7870`	`fix_infomask_from_infobits(xlrec->infobits_set,&htup->t_infomask,`
`7869`	`7871`	`&htup->t_infomask2);`
`7870`	`7872`
`@@ -7925,6 +7927,8 @@ heap_xlog_lock_updated(XLogRecPtr lsn, XLogRecord *record)`
`7925`	`7927`
`7926`	`7928`	`htup= (HeapTupleHeader)PageGetItem(page,lp);`
`7927`	`7929`
	`7930`	`+htup->t_infomask &= ~(HEAP_XMAX_BITS \|HEAP_MOVED);`
	`7931`	`+htup->t_infomask2 &= ~HEAP_KEYS_UPDATED;`
`7928`	`7932`	`fix_infomask_from_infobits(xlrec->infobits_set,&htup->t_infomask,`
`7929`	`7933`	`&htup->t_infomask2);`
`7930`	`7934`	`HeapTupleHeaderSetXmax(htup,xlrec->xmax);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit46acbeb

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments