Commit46a28f1

committed

Fixed everything in and surrounding createdb and dropdb to make it more

error-proof. Rearranged some old code and removed dead sections.

1 parentbfa3b59 commit46a28f1Copy full SHA for 46a28f1

File tree

+471

-840

lines changed

+471

-840

lines changed

Lines changed: 1 addition & 18 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/catalog/aclchk.c,v 1.32 1999/11/24 16:52:31 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/catalog/aclchk.c,v 1.33 2000/01/13 18:26:04 petere Exp $`
`11`	`11`	`*`
`12`	`12`	`* NOTES`
`13`	`13`	`* See acl.h.`
`@@ -358,23 +358,6 @@ pg_aclcheck(char relname, char usename, AclMode mode)`
`358`	`358`	`usename);`
`359`	`359`	`id= (AclId) ((Form_pg_shadow)GETSTRUCT(tuple))->usesysid;`
`360`	`360`
`361`		`-/*`
`362`		`- * for the 'pg_database' relation, check the usecreatedb field before`
`363`		`- * checking normal permissions`
`364`		`- */`
`365`		`-if (strcmp(DatabaseRelationName,relname)==0&&`
`366`		`-(((Form_pg_shadow)GETSTRUCT(tuple))->usecreatedb))`
`367`		`-{`
`368`		`-`
`369`		`-/*`
`370`		`- * note that even though the user can now append to the`
`371`		`- * pg_database table, there is still additional permissions`
`372`		`- * checking in dbcommands.c`
`373`		`- */`
`374`		`-if ((mode&ACL_WR)\|\| (mode&ACL_AP))`
`375`		`-returnACLCHECK_OK;`
`376`		`-}`
`377`		`-`
`378`	`361`	`/*`
`379`	`362`	`* Deny anyone permission to update a system catalog unless`
`380`	`363`	`* pg_shadow.usecatupd is set.(This is to let superusers protect`

Comments

(0)